Skip to content

fix: Panic instead of logging error of failing header validation #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alpe merged 4 commits into from
May 13, 2025
Merged

fix: Panic instead of logging error of failing header validation #2231

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87fa35e
Panic instead of logging error of failing header validation
Manav-Aggarwal Apr 30, 2025
41e5fff
Add comment on how to recover
Manav-Aggarwal Apr 30, 2025
f171898
Move validation before
Manav-Aggarwal Apr 30, 2025
5caea64
Merge branch 'main' into manav/panic_not_log
alpe May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move validation before
  • Loading branch information
@Manav-Aggarwal
Manav-Aggarwal committed Apr 30, 2025
commit f17189869fe17ae88b01fd7c0ad73a65878a119e
20 changes: 10 additions & 10 deletions block/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,15 +563,6 @@ func (m *Manager) publishBlockInternal(ctx context.Context) error {
}
}

newState, err := m.applyBlock(ctx, header, data)
if err != nil {
if ctx.Err() != nil {
return err
}
// if call to applyBlock fails, we halt the node, see https://github.com/cometbft/cometbft/pull/496
panic(err)
}

signature, err = m.getSignature(header.Header)
if err != nil {
return err
Expand All @@ -581,10 +572,19 @@ func (m *Manager) publishBlockInternal(ctx context.Context) error {
header.Signature = signature

if err := header.ValidateBasic(); err != nil {
// If this ever happens, for reovery, check for a mismatch between the configured signing key and the proposer address in the genesis file
// If this ever happens, for recovery, check for a mismatch between the configured signing key and the proposer address in the genesis file
panic(fmt.Errorf("critical: newly produced header failed validation: %w", err))
}

newState, err := m.applyBlock(ctx, header, data)
if err != nil {
if ctx.Err() != nil {
return err
}
// if call to applyBlock fails, we halt the node, see https://github.com/cometbft/cometbft/pull/496
panic(err)
}

// append metadata to Data before validating and saving
data.Metadata = &types.Metadata{
ChainID: header.ChainID(),
Expand Down