Skip to content

prevent empty block creation #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tac0turtle merged 15 commits into from
Apr 18, 2025
Merged

prevent empty block creation #2189

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a19c9e0
build all apps in ci
Apr 17, 2025
c990471
yamllint
Apr 17, 2025
f14bef0
ci naming
Apr 17, 2025
a7cb6a7
rename seeds to peers in log
Apr 17, 2025
3c5f1f0
minor cleanups
Apr 17, 2025
f8f1d39
fix error
Apr 17, 2025
223a832
++
Apr 17, 2025
56f3307
prevent empty block creation
Apr 17, 2025
0b7a5c9
make change in single
Apr 17, 2025
ba84a9a
Merge branch 'feature/exec_api' into marko/blockmanager_empty_blocks
tac0turtle Apr 17, 2025
9887858
error return
Apr 17, 2025
388dc1c
move errnobatch and use littleendian for lastsubmittedbactch instead …
Apr 17, 2025
5530a73
ammend
Apr 17, 2025
aca0b44
fix tests
Apr 18, 2025
67b68a8
Merge branch 'feature/exec_api' into marko/blockmanager_empty_blocks
tac0turtle Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
error return
  • Loading branch information
tac0turtle
tac0turtle committed Apr 17, 2025
commit 9887858e9972a40ae474fc26ea5ce61444d14b96
6 changes: 4 additions & 2 deletions block/manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,8 @@ func Test_publishBlock_NoBatch(t *testing.T) {
}

mockStore.On("GetMetadata", ctx, LastSubmittedHeightKey).Return([]byte{0}, nil)
m.pendingHeaders.init()
err = m.pendingHeaders.init()
require.NoError(err)

// Mock store calls for height and previous block/commit
currentHeight := uint64(1)
Expand Down Expand Up @@ -553,7 +554,8 @@ func Test_publishBlock_EmptyBatch(t *testing.T) {
}

mockStore.On("GetMetadata", ctx, LastSubmittedHeightKey).Return([]byte{0}, nil)
m.pendingHeaders.init()
err = m.pendingHeaders.init()
require.NoError(err)

// Mock store calls
currentHeight := uint64(1)
Expand Down