Skip to content

refactor: remove dependency to cometbft #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
randygrok merged 27 commits into from
Mar 5, 2025
Merged

refactor: remove dependency to cometbft #2035

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
11ec5fb
Move config default log level from comet to rollkit
randygrok Mar 4, 2025
7ab7387
Use instrumentation config from rollkit
randygrok Mar 4, 2025
7cab9e5
refactor: Migrate instrumentation config from CometBFT to Rollkit
randygrok Mar 4, 2025
726e153
refactor: Update node configuration to use Viper and remove CometBFT …
randygrok Mar 4, 2025
d01c738
Merge remote-tracking branch 'origin/feature/exec_api' into feature/c…
randygrok Mar 4, 2025
a0819f9
refactor: Remove proxy_app configuration in node commands
randygrok Mar 4, 2025
ede2690
refactor: Remove ABCI transport configuration flags
randygrok Mar 4, 2025
90096e7
refactor: Update P2P configuration to use 'p2p.laddr' instead of 'p2p…
randygrok Mar 4, 2025
d719600
refactor: Remove commented-out code and unused configurations in run_…
randygrok Mar 4, 2025
5fa72f2
refactor: Remove P2P external address configuration
randygrok Mar 4, 2025
3b97a57
Merge branch 'feature/exec_api' into feature/config-comet
randygrok Mar 5, 2025
31007ea
remove duplicated rollkit config
randygrok Mar 5, 2025
ec9add9
Merge branch 'feature/config-comet' of github.com-randy:rollkit/rollk…
randygrok Mar 5, 2025
2d99233
remove duplicate
randygrok Mar 5, 2025
2e53815
Markdown lint
randygrok Mar 5, 2025
08746a5
use default nodeRollkit
randygrok Mar 5, 2025
01f5412
Add conditionals to viper load
randygrok Mar 5, 2025
9892f0e
fix default url
randygrok Mar 5, 2025
7f57d49
fix units
randygrok Mar 5, 2025
b2fca53
update code
randygrok Mar 5, 2025
1feddf3
update docs
randygrok Mar 5, 2025
dfd8f01
remove links
randygrok Mar 5, 2025
48aaf04
fix files mdbook
randygrok Mar 5, 2025
2af5c65
fix dockerfile
randygrok Mar 5, 2025
75efbc8
add test coverage
randygrok Mar 5, 2025
7e1b2b9
fix lint errors
randygrok Mar 5, 2025
6319f6e
remove old comment
randygrok Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: Remove P2P external address configuration 
This modification removes the P2P external address configuration from Rollkit’s test files and documentation. The changes include:
	•	Removal of the --p2p.external-address flag in run_node_test.go
	•	Removal of the external address flag description in Rollkit’s startup documentation
  • Loading branch information
@randygrok
randygrok committed Mar 4, 2025
commit 5fa72f22e99aecdd58a27139ebd65e8134c5d40c
2 changes: 0 additions & 2 deletions cmd/rollkit/commands/run_node_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ func TestParseFlags(t *testing.T) {
"--db_backend", "cleverdb",
"--db_dir", "data2",
"--moniker", "yarik-playground2",
"--p2p.external-address", "127.0.0.0:26000",
"--p2p.laddr", "tcp://127.0.0.1:27000",
"--p2p.pex",
"--p2p.private_peer_ids", "1,2,3",
Expand Down Expand Up @@ -79,7 +78,6 @@ func TestParseFlags(t *testing.T) {
{"DBBackend", viper.GetString("db_backend"), "cleverdb"},
{"DBDir", viper.GetString("db_dir"), "data2"},
{"Moniker", viper.GetString("moniker"), "yarik-playground2"},
{"ExternalAddress", viper.GetString("p2p.external-address"), "127.0.0.0:26000"},
{"PexReactor", viper.GetBool("p2p.pex"), true},
{"PrivatePeerIDs", viper.GetString("p2p.private_peer_ids"), "1,2,3"},
{"SeedMode", viper.GetBool("p2p.seed_mode"), true},
Expand Down
1 change: 0 additions & 1 deletion cmd/rollkit/docs/rollkit_start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ rollkit start [flags]
--genesis_hash bytesHex optional SHA-256 hash of the genesis file
-h, --help help for start
--moniker string node name (default "Your Computer Username")
--p2p.external-address string ip:port address to advertise to peers for them to dial
--p2p.laddr string node listen address. (0.0.0.0:0 means any interface, any port) (default "tcp://0.0.0.0:26656")
--p2p.persistent_peers string comma-delimited ID@host:port persistent peers
--p2p.pex enable/disable Peer-Exchange (default true)
Expand Down