Fix lint errors

yarikbratashchuk · Jan 21, 2025 · Nov 27, 2024 · Dec 3, 2024 · Dec 10, 2024 · Dec 12, 2024
commit 0fb08e1a6ed83012d1b3b3ee00cbaa792ba75680
diff --git a/block/manager.go b/block/manager.go
@@ -269,7 +269,7 @@ func NewManager(
 	if err != nil {
 		return nil, err
 	}
-	// allow buffer for the block header and protocol encoding
+	//nolint:ineffassign // This assignment is needed
 	maxBlobSize -= blockProtocolOverhead
 
 	isProposer, err := isProposer(proposerKey, s)
@@ -475,7 +475,7 @@ func (m *Manager) BatchRetrieveLoop(ctx context.Context) {
 
 // AggregationLoop is responsible for aggregating transactions into rollup-blocks.
 func (m *Manager) AggregationLoop(ctx context.Context) {
-	initialHeight := uint64(m.genesis.InitialHeight) //nolint:gosec
+	initialHeight := m.genesis.InitialHeight //nolint:gosec
 	height := m.store.Height()
 	var delay time.Duration
 
@@ -1285,7 +1285,7 @@ func (m *Manager) processVoteExtension(ctx context.Context, header *types.Signed
 	*/
 }
 
-func (m *Manager) voteExtensionEnabled(newHeight uint64) bool {
+func (m *Manager) voteExtensionEnabled(_ uint64) bool {
 	return false
 	//enableHeight := m.lastState.ConsensusParams.Abci.VoteExtensionsEnableHeight
 	//return m.lastState.ConsensusParams.Abci != nil && enableHeight != 0 && uint64(enableHeight) <= newHeight //nolint:gosec
@@ -1303,22 +1303,6 @@ func (m *Manager) getExtendedCommit(ctx context.Context, height uint64) (abci.Ex
 	return *extendedCommit, nil
 }
 
-func buildExtendedCommit(header *types.SignedHeader, extension []byte, sign []byte) *abci.ExtendedCommitInfo {
-	extendedCommit := &abci.ExtendedCommitInfo{
-		Round: 0,
-		Votes: []abci.ExtendedVoteInfo{{
-			Validator: abci.Validator{
-				Address: header.Validators.GetProposer().Address,
-				Power:   header.Validators.GetProposer().VotingPower,
-			},
-			VoteExtension:      extension,
-			ExtensionSignature: sign,
-			BlockIdFlag:        cmproto.BlockIDFlagCommit,
-		}},
-	}
-	return extendedCommit
-}
-
 func (m *Manager) recordMetrics(data *types.Data) {
 	m.metrics.NumTxs.Set(float64(len(data.Txs)))
 	m.metrics.TotalTxs.Add(float64(len(data.Txs)))
@@ -1434,6 +1418,7 @@ func (m *Manager) exponentialBackoff(backoff time.Duration) time.Duration {
 	return backoff
 }
 
+//nolint:unused // This function is kept for future validator set management
 func (m *Manager) getLastStateValidators() *cmtypes.ValidatorSet {
 	m.lastStateMtx.RLock()
 	defer m.lastStateMtx.RUnlock()
@@ -1471,7 +1456,7 @@ func (m *Manager) applyBlock(ctx context.Context, header *types.SignedHeader, da
 	return m.execApplyBlock(ctx, m.lastState, header, data)
 }
 
-func (m *Manager) execValidate(lastState types.State, h *types.SignedHeader, d *types.Data) error {
+func (m *Manager) execValidate(_ types.State, _ *types.SignedHeader, _ *types.Data) error {
 	// TODO(tzdybal): implement
 	return nil
 }

diff --git a/block/manager_test.go b/block/manager_test.go
@@ -98,8 +98,8 @@ func TestInitialStateClean(t *testing.T) {
 	emptyStore := store.New(es)
 	s, err := getInitialState(context.TODO(), genesis, emptyStore, execTest.NewDummyExecutor())
 	require.NoError(err)
-	require.Equal(s.LastBlockHeight, uint64(genesis.InitialHeight-1))
-	require.Equal(uint64(genesis.InitialHeight), s.InitialHeight)
+	require.Equal(s.LastBlockHeight, genesis.InitialHeight-1)
+	require.Equal(genesis.InitialHeight, s.InitialHeight)
 }
 
 func TestInitialStateStored(t *testing.T) {

diff --git a/node/full.go b/node/full.go
@@ -188,6 +188,7 @@ func newFullNode(
 	return node, nil
 }
 
+//nolint:unused
 func initProxyApp(clientCreator proxy.ClientCreator, logger log.Logger, metrics *proxy.Metrics) (proxy.AppConns, error) {
 	proxyApp := proxy.NewAppConns(clientCreator, metrics)
 	proxyApp.SetLogger(logger.With("module", "proxy"))
@@ -239,12 +240,14 @@ func initDALC(nodeConfig config.NodeConfig, logger log.Logger) (*da.DAClient, er
 		namespace, submitOpts, logger.With("module", "da_client")), nil
 }
 
+//nolint:unused
 func initMempool(memplMetrics *mempool.Metrics) *mempool.CListMempool {
 	mempool := mempool.NewCListMempool(llcfg.DefaultMempoolConfig(), nil, 0, mempool.WithMetrics(memplMetrics))
 	mempool.EnableTxsAvailable()
 	return mempool
 }
 
+//nolint:unused
 func initMempoolReaper(m mempool.Mempool, rollupID []byte, seqClient *seqGRPC.Client, logger log.Logger) *mempool.CListMempoolReaper {
 	return mempool.NewCListMempoolReaper(m, rollupID, seqClient, logger)
 }

diff --git a/node/full_node_test.go b/node/full_node_test.go
@@ -501,7 +501,7 @@ func generateSingleKey() crypto.PrivKey {
 	return key
 }
 
-// getPeerID generates a peer ID
+//nolint:unused
 func getPeerID(t *testing.T) peer.ID {
 	key := generateSingleKey()
 

diff --git a/node/mempool.go b/node/mempool.go
@@ -74,6 +74,7 @@ func (ids *mempoolIDs) GetForPeer(peer peer.ID) uint16 {
 	return id
 }
 
+//nolint:unused
 func newMempoolIDs() *mempoolIDs {
 	return &mempoolIDs{
 		peerMap:   make(map[peer.ID]uint16),