Skip to content

fix: use batchtime from sequencer for header time, upgrade to latest go-da and go-sequencing #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gupadhyaya merged 21 commits into from
Oct 18, 2024
Merged

fix: use batchtime from sequencer for header time, upgrade to latest go-da and go-sequencing #1871

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b506986
upgrade to latest go-sequencing
gupadhyaya Oct 4, 2024
28d094c
use sequencer timestamp for header time
gupadhyaya Oct 4, 2024
266a4c4
upgrade go-da
gupadhyaya Oct 4, 2024
2e63f61
fix nil pointer
gupadhyaya Oct 4, 2024
d60614e
use test as default rollupId
gupadhyaya Oct 4, 2024
22407d0
minor
gupadhyaya Oct 4, 2024
c8163df
use batch Hash, add empty batches to queue to capture sequencer times…
gupadhyaya Oct 4, 2024
7104199
return error when no batch
gupadhyaya Oct 8, 2024
85a6e82
Merge remote-tracking branch 'origin/main' into seq_fixes
gupadhyaya Oct 8, 2024
6b74462
faster batch retrieval
gupadhyaya Oct 8, 2024
a682912
revert default retrieval time to 1s and fix mempool2node test
gupadhyaya Oct 9, 2024
e643842
fix cli issue
gupadhyaya Oct 9, 2024
f45fe69
Merge branch 'main' into seq_fixes
gupadhyaya Oct 9, 2024
f6ba822
test to TestChainID
gupadhyaya Oct 9, 2024
3549603
try fixing failing tests
gupadhyaya Oct 9, 2024
558cb1e
use multi-rollup sequencer and test name as chainId which is intern t…
gupadhyaya Oct 11, 2024
f072ab8
fix lint
gupadhyaya Oct 11, 2024
efa6433
siging to signing
gupadhyaya Oct 11, 2024
b8cc013
chainId to chainID
gupadhyaya Oct 11, 2024
d034e45
minor
gupadhyaya Oct 11, 2024
10bdaac
fix complicated checks in batch retrieve loop and add sanity check fo…
gupadhyaya Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix cli issue
  • Loading branch information
@gupadhyaya
gupadhyaya committed Oct 9, 2024
commit e64384281bf0d4afa1b0711c8c928400e19ac41b
6 changes: 3 additions & 3 deletions cmd/rollkit/commands/run_node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ func NewRunNodeCmd() *cobra.Command {

// use mock grpc sequencer server by default
if !cmd.Flags().Lookup("rollkit.sequencer_address").Changed {
srv, err := startMockSequencerServerGRPC(MockSequencerAddress)
srv, err := startMockSequencerServerGRPC(MockSequencerAddress, genDoc.ChainID)
if err != nil {
return fmt.Errorf("failed to launch mock sequencing server: %w", err)
}
Expand Down Expand Up @@ -247,8 +247,8 @@ func startMockDAServJSONRPC(ctx context.Context) (*proxy.Server, error) {
}

// startMockSequencerServerGRPC starts a mock gRPC server with the given listenAddress.
func startMockSequencerServerGRPC(listenAddress string) (*grpc.Server, error) {
dummySeq := seqTest.NewDummySequencer([]byte("test"))
func startMockSequencerServerGRPC(listenAddress string, rollupId string) (*grpc.Server, error) {
dummySeq := seqTest.NewDummySequencer([]byte(rollupId))
server := seqGRPC.NewServer(dummySeq, dummySeq, dummySeq)
lis, err := net.Listen("tcp", listenAddress)
if err != nil {
Expand Down