Skip to content

feat: rollkit rebuild command to update entrypoint #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yarikbratashchuk merged 11 commits into from
Jun 21, 2024
Merged

feat: rollkit rebuild command to update entrypoint #1707

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5b5e2dc
Rollkit rebuild command to update entrypoint
yarikbratashchuk Jun 5, 2024
f3f6594
Merge branch 'main' into yarik/rebuild
yarikbratashchuk Jun 14, 2024
4b8c846
Update docs
yarikbratashchuk Jun 14, 2024
aacf3d5
Rename entrypointBinary to entrypointBinaryFilePath as MSevey suggested
yarikbratashchuk Jun 14, 2024
dc3521a
Revert "Rename entrypointBinary to entrypointBinaryFilePath as MSevey…
yarikbratashchuk Jun 14, 2024
3039e34
Rename var
yarikbratashchuk Jun 14, 2024
a425084
Update cmd/rollkit/commands/rebuild.go
yarikbratashchuk Jun 15, 2024
a180647
Update cmd/rollkit/commands/rebuild.go
yarikbratashchuk Jun 15, 2024
aaf5e2e
go mod tidy, improve error message
yarikbratashchuk Jun 20, 2024
7031c2a
Merge branch 'main' into yarik/rebuild
yarikbratashchuk Jun 20, 2024
f6b94f1
Merge branch 'main' into yarik/rebuild
yarikbratashchuk Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
go mod tidy, improve error message
  • Loading branch information
@yarikbratashchuk
yarikbratashchuk committed Jun 20, 2024
commit aaf5e2e77d3a5b2dd73cb8242fc0ba3cb9e5b2a7
2 changes: 1 addition & 1 deletion cmd/rollkit/commands/intercept.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func buildEntrypoint(rootDir, entrypointSourceFile string, forceRebuild bool) (s

if !cometos.FileExists(entrypointBinaryFile) || forceRebuild {
if !cometos.FileExists(entrypointSourceFile) {
return "", fmt.Errorf("no entrypoint file: %s", entrypointSourceFile)
return "", fmt.Errorf("no entrypoint source file: %s", entrypointSourceFile)
}

// try to build the entrypoint as a go binary
Expand Down
3 changes: 1 addition & 2 deletions cmd/rollkit/commands/rebuild.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
package commands

import (
"fmt"
"os"
"log"

rollconf "github.com/rollkit/rollkit/config"

Expand Down