Skip to content

Housekeeping workflow broken  #950

Closed

Description

@MSevey

Overview

The housekeeping workflow is broken due to a permission/scope issue with passing in the secrets I believe.

This issue was identified on dependabot PRs but is present on team PRs as well: https://github.com/rollkit/rollkit/actions/runs/5026355079/jobs/9014531416

This bug is being missed normally because of the open trigger. When new commits are pushed to a PR, the housekeeping workflow isn't retriggering and since it is not required it gets dropped from the list of completed actions.

Example: #949

Recommendation

  1. Investigate the permissions issue and see if there is a github security model that is preventing secrets: inherit from working when calling relative workflows in other organizations.
  2. Look into updating the housekeeping workflow to trigger on all PR events and filter out at the step level which ones only make sense to only trigger on open. Or see if there is a way to re-trigger only failed steps.

Metadata

Metadata

Assignees

Labels

T:bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions