Skip to content

Documentation improvements: Aggregates - #1069

Merged
rasmus merged 1 commit into
eventflow:develop-v1from
alexeyfv:develop-v1
Jan 6, 2025
Merged

Documentation improvements: Aggregates#1069
rasmus merged 1 commit into
eventflow:develop-v1from
alexeyfv:develop-v1

Conversation

@alexeyfv

@alexeyfv alexeyfv commented Jan 5, 2025

Copy link
Copy Markdown
Contributor

Hello,

I made the following improvements to the Aggregate page:

  1. Added a link to the Identity page. Seems like it was missing.
  2. Briefly explained why it's important to use the SingleValueObjectConverter class with the Identity class.
  3. Changed the code snippet in the "Using Events" section to make it more clear.
  4. Added examples of how to modify aggregates using the IAggregateStore and the CQRS approach.

@CLAassistant

CLAassistant commented Jan 5, 2025 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@alexeyfv alexeyfv mentioned this pull request Jan 5, 2025
Closed
@rasmus
rasmus requested a review from Copilot January 6, 2025 19:04
Copilot AI reviewed Jan 6, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread Documentation/basics/aggregates.md
Comment thread Documentation/basics/aggregates.md
@rasmus

rasmus commented Jan 6, 2025

Copy link
Copy Markdown
Member

Some very odd comments from copilot. Testing it out to see if it actually has any value.

@rasmus

rasmus commented Jan 6, 2025

Copy link
Copy Markdown
Member

Thanks for the updates. It really means a lot!

@rasmus
rasmus merged commit 221f4ac into eventflow:develop-v1 Jan 6, 2025

This branch was previously deployed

1 inactive deployment
develop — 684f7e50 Deployed Jan 6, 2025 by alexeyfv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexeyfv @CLAassistant @rasmus