Skip to content

Don't attempt to pair up empty/unknown symbols with matching names #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LagoLunatic merged 1 commit into from
Sep 29, 2026
Merged

Don't attempt to pair up empty/unknown symbols with matching names #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Don't attempt to pair up empty/unknown symbols with matching names
  • Loading branch information
@LagoLunatic
LagoLunatic committed Sep 14, 2026
commit d9c8c4c20b531daba82ab5113a496cee3cee88d8
5 changes: 4 additions & 1 deletion objdiff-core/src/diff/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,10 @@ where
'obj: 'used,
{
obj.symbols.iter().enumerate().filter(move |&(symbol_idx, symbol)| {
!symbol.flags.contains(SymbolFlag::Ignored)
symbol.size != 0
&& !symbol.flags.contains(SymbolFlag::Ignored)
// e.g. .line and .debug sections
&& symbol_section_kind(obj, symbol) != SectionKind::Unknown
// Skip symbols that have already been matched
&& !used.is_some_and(|u| u.contains(&symbol_idx))
})
Expand Down
Loading