Store frames to guest as Map - #9287
Merged
Merged
Conversation
kevinsawicki
changed the title
Contributor
|
Spotted any other places for this kind of cleanup? |
Contributor
Author
Haven't seen any other obvious ones, most other object maps use generated ids that are incrementing numbers. |
kevinsawicki
force-pushed
the
store-frames-to-guest-as-map
branch
from
April 26, 2017 17:14
1819b6f to
91a1e5c
Compare
This was referenced Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using an object for this mapping causes errors to be thrown if the frame name matched a built-in object property (like
__proto__). Now it uses aMapwhich supports all frame names.