Skip to content

chore: remove node patches by using the preload feature - #41080

Merged
ckerr merged 1 commit into
mainfrom
preload-env
Jan 24, 2024
Merged

ckerr merged 1 commit into
mainfrom
preload-env

Conversation

@zcbenz

@zcbenz zcbenz commented Jan 23, 2024

Copy link
Copy Markdown
Contributor

Description of Change

With nodejs/node#51539 we will have an official way to inject things into node without relying on patches. This PR makes uses of the feature to remove a few node patches.

There are also some other patches that can be removed but require some refactoring, which I will do in following PRs.

Checklist

Release Notes

Notes: none

@zcbenz
zcbenz requested a review from a team as a code owner January 23, 2024 06:44
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Jan 23, 2024
@zcbenz zcbenz added semver/none target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. labels Jan 23, 2024

@ckerr ckerr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🎉

@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jan 24, 2024
@ckerr
ckerr merged commit d13a93f into main Jan 24, 2024
@ckerr
ckerr deleted the preload-env branch January 24, 2024 15:54
@release-clerk

release-clerk Bot commented Jan 24, 2024

Copy link
Copy Markdown

No Release Notes

@trop

trop Bot commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

I was unable to backport this PR to "27-x-y" cleanly;
you will need to perform this backport manually.

@trop trop Bot removed the target/27-x-y PR should also be added to the "27-x-y" branch. label Jan 24, 2024
@trop

trop Bot commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

I was unable to backport this PR to "28-x-y" cleanly;
you will need to perform this backport manually.

@trop trop Bot added needs-manual-bp/27-x-y and removed target/28-x-y PR should also be added to the "28-x-y" branch. labels Jan 24, 2024
@trop

trop Bot commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

I was unable to backport this PR to "29-x-y" cleanly;
you will need to perform this backport manually.

@trop trop Bot added needs-manual-bp/28-x-y needs-manual-bp/29-x-y and removed target/29-x-y PR should also be added to the "29-x-y" branch. labels Jan 24, 2024
@trop

trop Bot commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

@zcbenz has manually backported this PR to "29-x-y", please check out #41113

@trop

trop Bot commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

@zcbenz has manually backported this PR to "28-x-y", please check out #41114

@trop

trop Bot commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

@zcbenz has manually backported this PR to "27-x-y", please check out #41115

@trop trop Bot added merged/29-x-y PR was merged to the "29-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. and removed in-flight/29-x-y in-flight/28-x-y in-flight/27-x-y labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. semver/none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants