Repository navigation
chore: move node headers generation to electron - #39589
Merged
Merged
Conversation
codebytere
approved these changes
Aug 21, 2023
codebytere
left a comment
codebytere
left a comment
Member
There was a problem hiding this comment.
approving with one change i'd definitely prefer but won't block on
zcbenz
force-pushed
the
generate-headers-in-electron
branch
from
August 21, 2023 23:48
9f75362 to
3a1d798
Compare
|
No Release Notes |
This was referenced Aug 29, 2023
win32ss
pushed a commit
to win32ss/supermium-electron
that referenced
this pull request
Sep 24, 2023
ghost
mentioned this pull request
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
I find it almost impossible to upstream these changes to node since they are highly electron specific.
Refs nodejs/node#47637.
Release Notes
Notes: none