Skip to content

chore: rename built-in modules to bindings to match naming update in node - #37182

Merged
deepak1556 merged 1 commit into
mainfrom
miniak/linked-bindings
Feb 9, 2023
Merged

deepak1556 merged 1 commit into
mainfrom
miniak/linked-bindings

Conversation

@miniak

@miniak miniak commented Feb 8, 2023 •

Copy link
Copy Markdown
Contributor

Description of Change

Follow-up to nodejs/node#45551 and #37129

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Feb 8, 2023
@miniak miniak added semver/patch backwards-compatible bug fixes no-backport labels Feb 8, 2023
@miniak miniak self-assigned this Feb 8, 2023
@miniak
miniak requested a review from codebytere February 8, 2023 12:43
@miniak

miniak commented Feb 8, 2023

Copy link
Copy Markdown
Contributor Author

cc @codebytere

@deepak1556

Copy link
Copy Markdown
Member

Failing tests are unrelated, merging.

@deepak1556
deepak1556 merged commit 35a9e67 into main Feb 9, 2023
@deepak1556
deepak1556 deleted the miniak/linked-bindings branch February 9, 2023 01:31
@release-clerk

release-clerk Bot commented Feb 9, 2023

Copy link
Copy Markdown

No Release Notes

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
gecko19 pushed a commit to brightsign/electron that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-pr 🌱 PR opened recently no-backport semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants