Skip to content

pipeline tests - Ignore url.extension for ES < 8.14 #9623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewkroh merged 1 commit into from
Apr 17, 2024
Merged

pipeline tests - Ignore url.extension for ES < 8.14 #9623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
pipeline tests - Ignore url.extension for ES < 8.14 
Ignore the existence of an invalid  `url.extension` field. Stack versions < 8.14 had a
bug that populated the field with bad data. After a package uses a minimum stack version
of 8.14.0 then this addition to `dynamic_fields` can be removed.

This fixes errors like this which occur under v8.14.0

    test case failed: Expected results are different from actual ones: --- want
    +++ got
    @@ -1797,7 +1797,6 @@
                     "preserve_duplicate_custom_fields"
                 ],
                 "url": {
    -                "extension": "com/page",
                     "original": "www.example.com/page",
                     "path": "www.example.com/page"
                 }

Relates: elastic/elasticsearch#105689
  • Loading branch information
@andrewkroh
andrewkroh committed Apr 16, 2024
commit 0d1692d5ad232c9bc0da5316a9af22c105caf383
5 changes: 5 additions & 0 deletions packages/azure/data_stream/graphactivitylogs/_dev/test/pipeline/test-common-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
fields:
tags:
- preserve_original_event

dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
url.extension: '^.*$'
5 changes: 5 additions & 0 deletions packages/citrix_adc/data_stream/log/_dev/test/pipeline/test-common-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@ fields:
tags:
- preserve_original_event
- preserve_duplicate_custom_fields

dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
url.extension: '^.*$'
5 changes: 5 additions & 0 deletions packages/iis/data_stream/error/_dev/test/pipeline/test-common-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
fields:
tags:
- preserve_original_event

dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
url.extension: '^.*$'
5 changes: 5 additions & 0 deletions packages/imperva_cloud_waf/data_stream/event/_dev/test/pipeline/test-common-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@ fields:
tags:
- preserve_original_event
- preserve_duplicate_custom_fields

dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
url.extension: '^.*$'
3 changes: 3 additions & 0 deletions packages/keycloak/data_stream/log/_dev/test/pipeline/test-common-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
dynamic_fields:
"event.ingested": "^.*$"
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
url.extension: '^.*$'
fields:
tags:
- preserve_original_event
Expand Down
5 changes: 5 additions & 0 deletions packages/m365_defender/data_stream/event/_dev/test/pipeline/test-common-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@ fields:
tags:
- preserve_original_event
- preserve_duplicate_custom_fields

dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
url.extension: '^.*$'
6 changes: 6 additions & 0 deletions packages/netskope/data_stream/alerts/_dev/test/pipeline/test-common-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
fields:
tags:
- preserve_original_event

dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
netskope.alerts.url.extension: '^.*$'
netskope.alerts.page.url.extension: '^.*$'
5 changes: 5 additions & 0 deletions packages/netskope/data_stream/events/_dev/test/pipeline/test-common-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
fields:
tags:
- preserve_original_event

dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
netskope.events.url.extension: '^.*$'
5 changes: 5 additions & 0 deletions packages/ti_crowdstrike/data_stream/intel/_dev/test/pipeline/test-common-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@ fields:
tags:
- preserve_original_event
- preserve_duplicate_custom_fields

dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
url.extension: '^.*$'
5 changes: 5 additions & 0 deletions packages/ti_rapid7_threat_command/data_stream/ioc/_dev/test/pipeline/test-common-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
fields:
tags:
- preserve_original_event

dynamic_fields:
# This can be removed after ES 8.14 is the minimum version.
# Relates: https://github.com/elastic/elasticsearch/pull/105689
threat.indicator.url.extension: '^.*$'