Skip to content

[auditd_manager] Add audit rule files option to auditd_manager - #4905

Merged
marc-gr merged 3 commits into
elastic:mainfrom
marc-gr:audit_manager/audit_rule_files
Jan 3, 2023
Merged

[auditd_manager] Add audit rule files option to auditd_manager#4905
marc-gr merged 3 commits into
elastic:mainfrom
marc-gr:audit_manager/audit_rule_files

Conversation

@marc-gr

@marc-gr marc-gr commented Dec 28, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds the audit_rule_files option.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@marc-gr
marc-gr requested a review from a team as a code owner December 28, 2022 14:32
@elasticmachine

elasticmachine commented Dec 28, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Dec 28, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-03T08:42:29.034+0000

  • Duration: 14 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 21
Skipped 0
Total 21

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Dec 28, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 88.889% (8/9) 👍 22.222
Lines 90.404% (179/198) 👎 -9.596
Conditionals 100.0% (0/0) 💚

kcreddy
kcreddy reviewed Dec 29, 2022
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need some clarifications. Rest LGTM 👍🏼

Comment thread packages/auditd_manager/data_stream/auditd/agent/stream/auditd.yml.hbs
Comment thread packages/auditd_manager/data_stream/auditd/agent/stream/auditd.yml.hbs
@marc-gr
marc-gr requested a review from kcreddy January 3, 2023 08:42
kcreddy
kcreddy approved these changes Jan 3, 2023
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@marc-gr
marc-gr merged commit bdd2b7e into elastic:main Jan 3, 2023
@marc-gr
marc-gr deleted the audit_manager/audit_rule_files branch January 3, 2023 09:03
@elasticmachine

elasticmachine commented Jan 3, 2023

Copy link
Copy Markdown

Package auditd_manager - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=auditd_manager

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@marc-gr
[auditd_manager] Add audit rule files option to auditd_manager (elast…
e5d9969 
…ic#4905)

* Add audit rule files option to auditd_manager

* Add PR number

* Add constraints in template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marc-gr @elasticmachine @kcreddy