Skip to content

[Snyk and Cloudflare] Fix indefinite pagination - #3651

Merged
P1llus merged 2 commits into
elastic:mainfrom
P1llus:package_fix_pagination
Jul 5, 2022
Merged

[Snyk and Cloudflare] Fix indefinite pagination#3651
P1llus merged 2 commits into
elastic:mainfrom
P1llus:package_fix_pagination

Conversation

@P1llus

@P1llus P1llus commented Jul 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

There was no condition for pagination to end even if a page was empty, this PR adds checks for response body count, and errors out if its empty to end the pagination.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@P1llus P1llus added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:snyk Snyk Integration:cloudflare Cloudflare labels Jul 5, 2022
@P1llus
P1llus requested a review from a team as a code owner July 5, 2022 07:01
@elasticmachine

elasticmachine commented Jul 5, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Jul 5, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-05T07:01:41.776+0000

  • Duration: 16 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 106
Skipped 0
Total 106

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Jul 5, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (5/5) 💚 3.529
Classes 100.0% (5/5) 💚 3.529
Methods 100.0% (57/57) 💚 10.691
Lines 94.332% (882/935) 👍 3.389
Conditionals 100.0% (0/0) 💚

@P1llus
P1llus merged commit 428f805 into elastic:main Jul 5, 2022
@andrewkroh andrewkroh mentioned this pull request Jul 6, 2022
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@P1llus
[Snyk and Cloudflare] Fix indefinite pagination (elastic#3651)
3cbb917 
* adding fixes for snyk and cloudflare for indefinite pagination

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working, use only for issues Integration:cloudflare Cloudflare Integration:snyk Snyk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@P1llus @elasticmachine @efd6