Skip to content

[Github] Fix pagination and missing fields - #3607

Merged
efd6 merged 2 commits into
elastic:mainfrom
legoguy1000:3350-github-bug
Jun 28, 2022
Merged

[Github] Fix pagination and missing fields#3607
efd6 merged 2 commits into
elastic:mainfrom
legoguy1000:3350-github-bug

Conversation

@legoguy1000

@legoguy1000 legoguy1000 commented Jun 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Resolve issue of paignation and missing created_at field. I also updated the event.* categorization fields to be more accurate.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000
legoguy1000 marked this pull request as ready for review June 27, 2022 23:51
@legoguy1000
legoguy1000 requested a review from a team as a code owner June 27, 2022 23:51
@elasticmachine

elasticmachine commented Jun 27, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-28T00:08:41.567+0000

  • Duration: 14 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6

efd6 commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

/test

efd6
efd6 reviewed Jun 28, 2022
View reviewed changes
Comment thread packages/github/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
@elasticmachine

elasticmachine commented Jun 28, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.44
Classes 100.0% (1/1) 💚 3.44
Methods 100.0% (12/12) 💚 10.877
Lines 96.753% (149/154) 👍 6.718
Conditionals 100.0% (0/0) 💚

efd6
efd6 reviewed Jun 28, 2022
View reviewed changes
Comment thread packages/github/data_stream/audit/_dev/test/pipeline/test-audit-json.log
@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:github GitHub labels Jun 28, 2022
@elasticmachine

elasticmachine commented Jun 28, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
efd6 merged commit 6c883f3 into elastic:main Jun 28, 2022
@legoguy1000
legoguy1000 deleted the 3350-github-bug branch June 28, 2022 12:00
@andrewkroh andrewkroh mentioned this pull request Jun 30, 2022
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@legoguy1000
[Github] Fix pagination and missing fields (elastic#3607)
590ad57 
* elastic#3350: Github bugs

* add changelgog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working, use only for issues Integration:github GitHub

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Github audit logs pagination not working

3 participants

@legoguy1000 @elasticmachine @efd6