Skip to content

[httpjson] Add option to the manifest - #3545

Merged
marc-gr merged 2 commits into
elastic:mainfrom
marc-gr:httpjson_add-jwt-json
Jun 30, 2022
Merged

[httpjson] Add option to the manifest#3545
marc-gr merged 2 commits into
elastic:mainfrom
marc-gr:httpjson_add-jwt-json

Conversation

@marc-gr

@marc-gr marc-gr commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Exposes new option oauth_google_jwt_json added in 8.4.0

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@marc-gr
marc-gr requested a review from a team as a code owner June 21, 2022 08:23
@elasticmachine

elasticmachine commented Jun 21, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Jun 21, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-30T11:30:03.660+0000

  • Duration: 18 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Jun 21, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.401
Classes 100.0% (0/0) 💚 3.401
Methods 100.0% (3/3) 💚 11.25
Lines 100.0% (0/0) 💚 10.053
Conditionals 100.0% (0/0) 💚

efd6
efd6 approved these changes Jun 22, 2022
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you are happy with the non-breakingness.

Comment thread packages/httpjson/changelog.yml Outdated

@efd6 efd6 Jun 22, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this breaking since it now depends on 8.4?

@marc-gr marc-gr Jun 22, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't consider it breaking, users with stack < 8.4 won't see it, and users with it installed previously and in 8.4 will be able to upgrade without breaking. Not sure if we want to bump major if the stack version increases as a rule of thumb though, maybe @jamiehynds has some thoughts?

@marc-gr
marc-gr force-pushed the httpjson_add-jwt-json branch from 8974951 to f82e992 Compare June 30, 2022 11:29
@marc-gr
marc-gr merged commit ed17576 into elastic:main Jun 30, 2022
@marc-gr
marc-gr deleted the httpjson_add-jwt-json branch June 30, 2022 12:07
@andrewkroh andrewkroh mentioned this pull request Jul 6, 2022
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@marc-gr
[httpjson] Add option to the manifest (elastic#3545)
3f8aaa3 
* Add  option to the manifest

* Add changelog pr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request Integration:httpjson Custom API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marc-gr @elasticmachine @efd6