Skip to content

network_traffic: add mappings for process.* fields - #3515

Merged
efd6 merged 2 commits into
elastic:mainfrom
efd6:3512-network_traffic
Jun 29, 2022
Merged

network_traffic: add mappings for process.* fields#3515
efd6 merged 2 commits into
elastic:mainfrom
efd6:3512-network_traffic

Conversation

@efd6

@efd6 efd6 commented Jun 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds mappings for process.* fields at the root level.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • I have added the fields to all the data streams and not just the 4 that were noted in the issue since the beat field.yml includes process.* in the common set.

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:network_traffic Network Packet Capture labels Jun 16, 2022
@efd6 efd6 self-assigned this Jun 16, 2022
@efd6
efd6 force-pushed the 3512-network_traffic branch from 9bfa71c to 57df919 Compare June 16, 2022 06:56
@elasticmachine

elasticmachine commented Jun 16, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-29T00:36:54.944+0000

  • Duration: 73 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 264
Skipped 0
Total 264

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Jun 16, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.401
Classes 100.0% (0/0) 💚 3.401
Methods 71.875% (46/64) 👎 -16.987
Lines 100.0% (0/0) 💚 10.053
Conditionals 100.0% (0/0) 💚

@efd6
efd6 marked this pull request as ready for review June 16, 2022 09:37
@efd6
efd6 requested a review from a team as a code owner June 16, 2022 09:37
@elasticmachine

elasticmachine commented Jun 16, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
efd6 force-pushed the 3512-network_traffic branch from 57df919 to e09a9fd Compare June 23, 2022 23:34
andrewkroh
andrewkroh reviewed Jun 24, 2022
View reviewed changes
Comment thread packages/network_traffic/data_stream/amqp/fields/beats.yml Outdated
@efd6
efd6 force-pushed the 3512-network_traffic branch from e09a9fd to 01b2648 Compare June 29, 2022 00:36
@efd6
efd6 requested a review from andrewkroh June 29, 2022 00:37
@efd6

efd6 commented Jun 29, 2022

Copy link
Copy Markdown
Contributor Author

It would be nice if process.* could be placed on server and client according to ECS.

@efd6
efd6 merged commit 12529d0 into elastic:main Jun 29, 2022
@efd6
efd6 deleted the 3512-network_traffic branch June 29, 2022 01:53
@andrewkroh andrewkroh mentioned this pull request Jun 30, 2022
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
network_traffic: add mappings for process.* fields (elastic#3515)
1122c40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@andrewkroh andrewkroh andrewkroh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@efd6 efd6

Labels

bug Something isn't working, use only for issues Integration:network_traffic Network Packet Capture

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[network_traffic] process.start is missing from mappings

3 participants

@efd6 @elasticmachine @andrewkroh