Skip to content

network_traffic: remove invalid value from event.category in SIP sample event - #3343

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:3329-network-traffic
May 16, 2022
Merged

network_traffic: remove invalid value from event.category in SIP sample event#3343
efd6 merged 1 commit into
elastic:mainfrom
efd6:3329-network-traffic

Conversation

@efd6

@efd6 efd6 commented May 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This change removes an invalid value in the SIP data set.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

See #3016 (comment)

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:network_traffic Network Packet Capture labels May 11, 2022
@efd6
efd6 requested a review from a team as a code owner May 11, 2022 23:56
@elasticmachine

elasticmachine commented May 11, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented May 12, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-13T08:02:45.814+0000

  • Duration: 70 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 264
Skipped 0
Total 264

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented May 12, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.659
Classes 100.0% (0/0) 💚 3.659
Methods 71.875% (46/64) 👎 -17.009
Lines 100.0% (0/0) 💚 9.897
Conditionals 100.0% (0/0) 💚

@efd6 efd6 self-assigned this May 12, 2022
r00tu53r
r00tu53r reviewed May 12, 2022
View reviewed changes
Comment thread packages/network_traffic/changelog.yml Outdated

@r00tu53r r00tu53r May 12, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update PR number xxxx -> 3343

@efd6 efd6 May 12, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

efd6
efd6 commented May 12, 2022
View reviewed changes
Comment thread packages/network_traffic/changelog.yml Outdated
@efd6

efd6 commented May 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This is an incomplete fix since the field values in question originate in packet beat in the SIP plugin. There is a change proposed there to resolve the root issue (should sneak in before the FF).

r00tu53r
r00tu53r previously approved these changes May 12, 2022
View reviewed changes
@efd6
efd6 force-pushed the 3329-network-traffic branch from 9dc78d4 to 538df8d Compare May 13, 2022 07:13
@efd6
efd6 requested a review from r00tu53r May 13, 2022 07:13
@efd6
efd6 force-pushed the 3329-network-traffic branch from 538df8d to 378f156 Compare May 13, 2022 08:02
@efd6
efd6 dismissed r00tu53r’s stale review May 14, 2022 02:38

Significant changes since approval.

r00tu53r
r00tu53r approved these changes May 16, 2022
View reviewed changes

@r00tu53r r00tu53r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6
efd6 merged commit f5c0250 into elastic:main May 16, 2022
@efd6 efd6 mentioned this pull request May 16, 2022
Closed
@andrewkroh andrewkroh mentioned this pull request May 22, 2022
Closed
@andrewkroh andrewkroh mentioned this pull request May 31, 2022
Merged
@efd6
efd6 deleted the 3329-network-traffic branch February 5, 2025 22:13
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
network_traffic: remove invalid value from event.category in SIP data…
ebd7864 
… set (elastic#3343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@r00tu53r r00tu53r r00tu53r approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@efd6 efd6

Labels

bug Something isn't working, use only for issues Integration:network_traffic Network Packet Capture

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efd6 @elasticmachine @r00tu53r