Skip to content

[fortinet] Improve firewall input options - #3319

Merged
taylor-swanson merged 3 commits into
elastic:mainfrom
taylor-swanson:inputs-fortinet
May 12, 2022
Merged

[fortinet] Improve firewall input options#3319
taylor-swanson merged 3 commits into
elastic:mainfrom
taylor-swanson:inputs-fortinet

Conversation

@taylor-swanson

@taylor-swanson taylor-swanson commented May 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Add TLS support and custom TCP options

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/fortinet && elastic-package test

Related issues

Screenshots

fortinet

@taylor-swanson
[fortinet] Improve firewall input options
528e82f 
- Add TLS support and custom TCP options
@taylor-swanson taylor-swanson added enhancement New feature or request Team:Security-External Integrations Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source] labels May 10, 2022
@taylor-swanson taylor-swanson self-assigned this May 10, 2022
@elasticmachine

elasticmachine commented May 10, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T07:54:56.717+0000

  • Duration: 25 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented May 10, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (7/7) 💚 3.597
Classes 100.0% (7/7) 💚 3.597
Methods 89.552% (60/67) 👍 1.306
Lines 89.837% (1211/1348) 👍 0.724
Conditionals 100.0% (0/0) 💚

@taylor-swanson
taylor-swanson marked this pull request as ready for review May 10, 2022 16:21
@taylor-swanson
taylor-swanson requested a review from a team as a code owner May 10, 2022 16:21
@elasticmachine

elasticmachine commented May 10, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

efd6
efd6 reviewed May 11, 2022
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be a TLS test?

@taylor-swanson

taylor-swanson commented May 11, 2022

Copy link
Copy Markdown
Contributor Author

Will there be a TLS test?

TLS test has been added.

@taylor-swanson
taylor-swanson merged commit 8eb72de into elastic:main May 12, 2022
@taylor-swanson
taylor-swanson deleted the inputs-fortinet branch May 12, 2022 19:48
This was referenced May 22, 2022
Closed
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@taylor-swanson
[fortinet] Improve firewall input options (elastic#3319)
6867ba4 
- Add TLS support and custom TCP options
- Add system tests for TCP/TLS input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels

enhancement New feature or request Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taylor-swanson @elasticmachine @efd6