Skip to content

[cisco_ftd] Add TCP input with TLS support - #3313

Merged
taylor-swanson merged 2 commits into
elastic:mainfrom
taylor-swanson:inputs-cisco-ftd
May 11, 2022
Merged

[cisco_ftd] Add TCP input with TLS support#3313
taylor-swanson merged 2 commits into
elastic:mainfrom
taylor-swanson:inputs-cisco-ftd

Conversation

@taylor-swanson

@taylor-swanson taylor-swanson commented May 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Add TCP input, with TLS and custom options support
  • Add system test for TCP input

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/cisco_ftd && elastic-package test

Related issues

Screenshots

cisco_ftd

@taylor-swanson
[cisco_ftd] Add TCP input with TLS support
933299a 
- Add TCP input, with TLS and custom options support
- Add system test for TCP input
@taylor-swanson taylor-swanson self-assigned this May 10, 2022
@elasticmachine

elasticmachine commented May 10, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-10T15:31:58.349+0000

  • Duration: 20 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 18
Skipped 0
Total 18

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented May 10, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.14
Classes 100.0% (1/1) 💚 3.14
Methods 100.0% (17/17) 💚 11.558
Lines 66.522% (1073/1613) 👎 -22.577
Conditionals 100.0% (0/0) 💚

@taylor-swanson
taylor-swanson marked this pull request as ready for review May 10, 2022 13:55
@taylor-swanson
taylor-swanson requested a review from a team as a code owner May 10, 2022 13:55
@elasticmachine

elasticmachine commented May 10, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

r00tu53r
r00tu53r approved these changes May 11, 2022
View reviewed changes

@r00tu53r r00tu53r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylor-swanson
taylor-swanson merged commit 3c41132 into elastic:main May 11, 2022
@taylor-swanson
taylor-swanson deleted the inputs-cisco-ftd branch May 11, 2022 13:27
This was referenced May 22, 2022
Closed
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@taylor-swanson
[cisco_ftd] Add TCP input with TLS support (elastic#3313)
a9fb00d 
- Add TCP input, with TLS and custom options support
- Add system test for TCP input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@r00tu53r r00tu53r r00tu53r approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@taylor-swanson taylor-swanson

Labels

8.3-candidate enhancement New feature or request Integration:cisco_ftd Cisco FTD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taylor-swanson @elasticmachine @r00tu53r