Skip to content

[mimecast] Add more use cases for parsing audit events - #3231

Merged
efd6 merged 5 commits into
elastic:mainfrom
djordje-adzemovic-devtech:audit-event-parsing-se-cases
May 10, 2022
Merged

[mimecast] Add more use cases for parsing audit events#3231
efd6 merged 5 commits into
elastic:mainfrom
djordje-adzemovic-devtech:audit-event-parsing-se-cases

Conversation

@djordje-adzemovic-devtech

@djordje-adzemovic-devtech djordje-adzemovic-devtech commented Apr 29, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@djordje-adzemovic-devtech
djordje-adzemovic-devtech requested a review from a team as a code owner April 29, 2022 11:39
@elasticmachine

elasticmachine commented Apr 29, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-09T11:35:09.322+0000

  • Duration: 19 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 61
Skipped 0
Total 61

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

efd6
efd6 reviewed May 1, 2022
View reviewed changes
Comment thread packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/mimecast/data_stream/audit_events/elasticsearch/ingest_pipeline/default.yml Outdated
@efd6

efd6 commented May 1, 2022

Copy link
Copy Markdown
Contributor

/test

@efd6

efd6 commented May 5, 2022

Copy link
Copy Markdown
Contributor

/test

@djordje-adzemovic-devtech

djordje-adzemovic-devtech commented May 9, 2022

Copy link
Copy Markdown
Contributor Author

Can someone re-trigger tests please?

@r00tu53r

r00tu53r commented May 9, 2022

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

elasticmachine commented May 9, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 100.0% (8/8) 💚 3.597
Classes 100.0% (8/8) 💚 3.597
Methods 92.174% (106/115) 👍 3.935
Lines 83.126% (1202/1446) 👎 -5.812
Conditionals 100.0% (0/0) 💚

efd6
efd6 reviewed May 9, 2022
View reviewed changes
Comment thread packages/mimecast/data_stream/audit_events/fields/field.yml Outdated
@efd6

efd6 commented May 9, 2022

Copy link
Copy Markdown
Contributor

/test

@djordje-adzemovic-devtech

djordje-adzemovic-devtech commented May 10, 2022

Copy link
Copy Markdown
Contributor Author

Is it ok to be merged now?

efd6
efd6 approved these changes May 10, 2022
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6
efd6 merged commit a1603c5 into elastic:main May 10, 2022
This was referenced May 22, 2022
Closed
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@djordje-adzemovic-devtech
[mimecast] Add more use cases for parsing audit events (elastic#3231)
037ccef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@djordje-adzemovic-devtech @elasticmachine @efd6 @r00tu53r