Skip to content

fireeye: move invalid field values - #3099

Merged
efd6 merged 4 commits into
elastic:mainfrom
efd6:3053-fireeye
Apr 19, 2022
Merged

fireeye: move invalid field values#3099
efd6 merged 4 commits into
elastic:mainfrom
efd6:3053-fireeye

Conversation

@efd6

@efd6 efd6 commented Apr 14, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

This moves invalid field values to conform with ECS.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:fireeye FireEye Network Security (Community supported) labels Apr 14, 2022
@efd6 efd6 self-assigned this Apr 14, 2022
@efd6
efd6 requested a review from a team as a code owner April 14, 2022 07:56
@elasticmachine

elasticmachine commented Apr 14, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Apr 14, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-19T21:07:12.113+0000

  • Duration: 15 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

andrewkroh
andrewkroh reviewed Apr 18, 2022
View reviewed changes
Comment thread packages/fireeye/data_stream/nx/elasticsearch/ingest_pipeline/default.yml Outdated
if: ctx?.event?.type == 'fileinfo'
- set:
field: event.type
value: info

@andrewkroh andrewkroh Apr 18, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

event.type should be an array. https://www.elastic.co/guide/en/ecs/current/ecs-event.html#field-event-type

@efd6
efd6 requested a review from andrewkroh April 19, 2022 02:57
andrewkroh
andrewkroh approved these changes Apr 19, 2022
View reviewed changes
Comment thread packages/fireeye/changelog.yml Outdated
@efd6 @andrewkroh
Update packages/fireeye/changelog.yml
5f0ac6f 
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
@efd6
efd6 merged commit 0ee2c30 into elastic:main Apr 19, 2022
@efd6
efd6 deleted the 3053-fireeye branch April 19, 2022 23:31
@andrewkroh andrewkroh mentioned this pull request May 2, 2022
Merged
@efd6 efd6 mentioned this pull request May 11, 2022
Merged
4 tasks done
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6 @andrewkroh
fireeye: move invalid field values (elastic#3099)
e3f5bdc 
* remove event.ingested
* move invalid field values

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@andrewkroh andrewkroh andrewkroh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@efd6 efd6

Labels

bug Something isn't working, use only for issues Integration:fireeye FireEye Network Security (Community supported)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fireeye using invalid field values according to ECS

3 participants

@efd6 @elasticmachine @andrewkroh