Repository navigation
Transfer Linux and Windows team ownership to security-service-integrations #20626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Severity: 🟠 High
confidence: highpath: packages/auditd/manifest.yml:32All 16 package manifests change owner.github but none bump the package version or add a changelog entry, so the new owner never reaches the published packages. Bump each package's patch version and add a matching changelog entry.
Details
This PR edits
owner.githubin 16 package manifests (auditd, auditd_manager, fim, hid_bravura_monitor, macos, microsoft_dhcp, microsoft_dnsserver, microsoft_exchange_server, mysql_enterprise, network_traffic, osquery, sysmon_linux, system_audit, unifiedlogs, windows_etw, winlog) without touching a singlechangelog.ymlorversion:field — no changelog file appears in the changed-file set.Packages are published to EPR per version. With the version unchanged, none of these manifest edits are ever released: every package already published on epr.elastic.co keeps
elastic/sec-linux-platform/elastic/sec-windows-platformas its owner, even though those teams are being dissolved by this handover. Only the in-repo copy is updated.The repo's own contribution docs require both steps for any package change (docs/extend/_publish_an_integration.md, step 2 'Add a changelog entry' and step 5 'Bump the package version appropriately'). The precedent for exactly this kind of change is consistent: merged ownership-transfer PR 17982 bumped
cloud_asset_inventoryandcloud_security_postureand added a 'Transfer package ownership to ...' changelog entry to each, and packages/auditd/changelog.yml already carries a3.19.1entry with description 'Changed owners' from a previous transfer.I am flagging this once on auditd rather than 16 times; the same fix is needed in all 16 packages. The
.github/CODEOWNERSchange itself is correct and complete — nosec-linux-platform/sec-windows-platformreference remains underpackages/, the manifest owner of every touched package is listed in its CODEOWNERS entry (sodev/codeownersCheck() still passes), the duplicate teams on/packages/system/manifest.ymland/packages/system/changelog.ymlwere correctly collapsed to a single entry, and every data-stream-level entry still resolves to exactly one team.Recommendation:
For each of the 16 packages, bump the patch version in
manifest.ymland prepend a matching entry tochangelog.yml. For auditd (currently3.24.0):Repeat for auditd_manager, fim, hid_bravura_monitor, macos, microsoft_dhcp, microsoft_dnsserver, microsoft_exchange_server, mysql_enterprise, network_traffic, osquery, sysmon_linux, system_audit, unifiedlogs, windows_etw and winlog, using each package's own current version.
🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills