Skip to content
Prev Previous commit
Next Next commit
ssi: address review feedback on PR 20572 (1/4)
Fix twelve inline comments from the PR review:

- Changelogs for 35 packages incorrectly claimed preserve_original_event
  was added; those packages already had it before this series. Description
  shortened to "Add tags to ingest pipeline processors." for packages where
  nothing was added to the on_failure block.

- carbon_black_cloud/watchlist_hit: the append_related_hosts_6d9a788e
  processor appended user.domain but was gated on ctx.host?.hostname;
  guard corrected to ctx.user?.domain, matching alert_v7 and endpoint_event.

- azure/signinlogs: tag azure-json-keys-to-snake-case renamed to
  azure_json_keys_to_snake_case (hyphens to underscores).

- azure/signinlogs, darktrace/ai_analyst_alert, darktrace/model_breach_alert
  (three scripts): single-line Painless sources reformatted with source: |-
  for readability.

- amazon_security_lake/pipeline_category_discovery.yml: add missing
  trailing newline.

- claroty_ctd/event: tag script_to_drop_N/A_values_fields renamed to
  script_to_drop_NA_values_fields (slash was not a valid identifier char).

Also update fix_pipeline_tags.py --normalize to convert hyphens to
underscores in tag stems (same logic as the asterisk-stripping pass).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
  • Loading branch information
kcreddy and claude committed Aug 19, 2026
commit b714aa16d92ebe04c325bcfdb6fb43808f59e08f
2 changes: 1 addition & 1 deletion packages/1password/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.38.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.37.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/abnormal_security/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.17.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.16.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/akamai/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "4.1.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- description: Remove two redundant no-op `rename` processors in the `siem` data stream.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ processors:
field: rule.version
tag: set_rule_version_bed73329
copy_from: ocsf.cis_benchmark_result.rule.version
ignore_empty_value: true
ignore_empty_value: true
2 changes: 1 addition & 1 deletion packages/atlassian_bitbucket/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "2.11.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "2.10.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/auth0/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.27.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.26.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/authentik/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.12.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.11.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/aws_securityhub/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.3.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.2.2"
Expand Down
2 changes: 1 addition & 1 deletion packages/azure/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
- version: "1.39.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- description: Remove a redundant no-op `rename` processor for `properties.activity_datetime` in the `provisioning` data stream.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ processors:
target_field: azure.signinlogs
- script:
description: Convert Azure JSON keys to snake case.
tag: azure-json-keys-to-snake-case_ffb87af5
tag: azure_json_keys_to_snake_case_ffb87af5
lang: painless
source: |
Map keysToSnakeCase(Map m) {
Expand Down Expand Up @@ -228,7 +228,16 @@ processors:
- script:
tag: script_build_message_field_using_combination_ee25521c
description: Build message field using a combination of failure reason and additional details
source: "String reason = ctx?.azure?.signinlogs?.properties?.status?.failure_reason; String details = ctx?.azure?.signinlogs?.properties?.status?.additional_details; if (reason != null && details != null) { ctx['message'] = reason + ' (' + details + ')'; } else if (reason != null) { ctx['message'] = reason; } else if (details != null) { ctx['message'] = details; }"
source: |-
String reason = ctx?.azure?.signinlogs?.properties?.status?.failure_reason;
String details = ctx?.azure?.signinlogs?.properties?.status?.additional_details;
if (reason != null && details != null) {
ctx['message'] = reason + ' (' + details + ')';
} else if (reason != null) {
ctx['message'] = reason;
} else if (details != null) {
ctx['message'] = details;
}

- remove:
tag: remove_azure_signinlogs_properties_status_failure_reason_172a2fd8
Expand Down
2 changes: 1 addition & 1 deletion packages/azure_frontdoor/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "2.6.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "2.5.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/bbot/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.5.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.4.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/beelzebub/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "0.5.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "0.4.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/beyondtrust_epm/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "0.2.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "0.1.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/beyondtrust_isi/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "0.2.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: 0.1.0
Expand Down
2 changes: 1 addition & 1 deletion packages/beyondtrust_pra/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.3.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.2.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/bitdefender/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "2.13.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "2.12.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/bitwarden/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.22.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.21.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/blacklens/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.4.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.3.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/canva/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.1.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.0.0"
Expand Down
3 changes: 3 additions & 0 deletions packages/carbon_black_cloud/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
- description: Remove two redundant no-op processors in the `endpoint_event` and `watchlist_hit` data streams.
type: bugfix
link: https://github.com/elastic/integrations/pull/20572
- description: Fix incorrect guard on `related.hosts` append in the `watchlist_hit` data stream. The processor appended `user.domain` when `host.hostname` was non-null rather than when `user.domain` was non-null, matching the correct guard used in sibling data streams.
type: bugfix
link: https://github.com/elastic/integrations/pull/20572
- version: "4.4.1"
changes:
- description: Set agentless deployment mode `release` field to `ga`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ processors:
tag: append_related_hosts_6d9a788e
Comment thread
kcreddy marked this conversation as resolved.
Resolved
field: related.hosts
value: '{{{user.domain}}}'
if: ctx.host?.hostname != null
if: ctx.user?.domain != null
allow_duplicates: false
ignore_failure: true
- script:
Expand Down
2 changes: 1 addition & 1 deletion packages/carbonblack_edr/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.22.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.21.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/checkpoint_email/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.7.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.6.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/checkpoint_harmony_endpoint/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.5.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.4.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/cisa_kevs/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.11.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.10.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/cisco_duo/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "2.12.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "2.11.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/cisco_secure_endpoint/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "2.37.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- description: Remove a redundant no-op `rename` processor for `process.hash.md5` in the `event` data stream.
Expand Down
2 changes: 1 addition & 1 deletion packages/claroty_ctd/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.6.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.5.1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Pipeline for processing Event logs.
processors:
- script:
description: Drops fields which have N/A values recursively.
tag: script_to_drop_N/A_values_fields_be39f122
tag: script_to_drop_NA_values_fields_be39f122
lang: painless
source: |-
boolean drop(Object o) {
Expand Down
2 changes: 1 addition & 1 deletion packages/claroty_xdome/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.3.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.2.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/crowdstrike/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "4.8.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "4.7.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/cyberark_epm/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.6.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.5.2"
Expand Down
2 changes: 1 addition & 1 deletion packages/cyberark_pta/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.16.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.15.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/cybereason/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "1.9.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "1.8.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/cylance/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "0.25.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "0.24.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/darktrace/changelog.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# newer versions go on top
- version: "2.4.0"
changes:
- description: Add tags to ingest pipeline processors and add `preserve_original_event` to pipeline-level `on_failure` handlers.
- description: Add tags to ingest pipeline processors.
type: enhancement
link: https://github.com/elastic/integrations/pull/20572
- version: "2.3.1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,12 @@ processors:
ignore_failure: true
params:
NANOS_IN_A_MILLI_SECOND: 1000000
source: def duration = new ArrayList(); for (event in ctx.json.periods) { duration.add((event?.end - event?.start) * params.NANOS_IN_A_MILLI_SECOND); } ctx.event.duration = duration;
source: |-
def duration = new ArrayList();
for (event in ctx.json.periods) {
duration.add((event?.end - event?.start) * params.NANOS_IN_A_MILLI_SECOND);
}
ctx.event.duration = duration;
- foreach:
tag: foreach_json_periods_9de45bc0
field: json.periods
Expand Down
Loading