Skip to content

[backport 2.0] GCP infra manager link - #17641

Closed
amirbenun wants to merge 9 commits into
backport-cloud_security_posture-2.0from
fix-gcp-cloud-shell-url-csp-2-0
Closed

[backport 2.0] GCP infra manager link#17641
amirbenun wants to merge 9 commits into
backport-cloud_security_posture-2.0from
fix-gcp-cloud-shell-url-csp-2-0

Conversation

@amirbenun

@amirbenun amirbenun commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

amirbenun and others added 8 commits February 5, 2026 15:32
@amirbenun @cursoragent
Backport GCP CloudShell URL change to CSP 2.0.x
6d75769 
Co-authored-by: Cursor <cursoragent@cursor.com>
@amirbenun @cursoragent
Fix cloudshell_git_branch to use 8.19
2da7db9 
Co-authored-by: Cursor <cursoragent@cursor.com>
@amirbenun @cursoragent
Trigger CI re-run
4595f36 
Co-authored-by: Cursor <cursoragent@cursor.com>
@amirbenun @cursoragent
Update Go version to 1.25.3
a087b8e 
Fix CI failure caused by Go 1.24.2 no longer being available for download.

Co-authored-by: Cursor <cursoragent@cursor.com>
@amirbenun @cursoragent
Update GVM to v0.6.0 and Go to 1.25.7
e85ad74 
GVM v0.5.2 uses the old storage.googleapis.com URL format which now
returns 403 errors. GVM v0.6.0 uses go.dev/dl which properly redirects
to the working download URLs.

Also update .go-version to 1.25.7 (current stable).

Co-authored-by: Cursor <cursoragent@cursor.com>
@amirbenun
chore: empty commit to re-trigger CI
bd08548
@amirbenun
Keep only cloud_security_posture package on this branch
bf0e2f7
@amirbenun
Revert "Keep only cloud_security_posture package on this branch"
c81e9fe 
This reverts commit bf0e2f7.
Copilot AI review requested due to automatic review settings March 3, 2026 14:33
@amirbenun
amirbenun requested a review from a team as a code owner March 3, 2026 14:33
Copilot AI reviewed Mar 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backports an update to the Cloud Security Posture integration by changing the GCP CloudShell default URL to point at the newer Infrastructure Manager deployment path, and bumps the package version accordingly. The PR also updates repo/CI Go toolchain configuration.

Changes:

  • Bump cloud_security_posture package version to 2.0.2 and update the GCP CloudShell default URL.
  • Add 2.0.2 entry to the package changelog.
  • Update repository Go toolchain version and Buildkite gvm installer version.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/cloud_security_posture/manifest.yml Bumps package version and updates the GCP CloudShell URL to the Infrastructure Manager path.
packages/cloud_security_posture/changelog.yml Adds a changelog entry for version 2.0.2.
.go-version Bumps the Go toolchain version used by CI and local tooling.
.buildkite/pipeline.yml Updates SETUP_GVM_VERSION used to install Go in CI.
.buildkite/pipeline.serverless.yml Updates SETUP_GVM_VERSION used to install Go in CI.
.buildkite/pipeline.schedule-weekly.yml Updates SETUP_GVM_VERSION used to install Go in CI.
.buildkite/pipeline.schedule-daily.yml Updates SETUP_GVM_VERSION used to install Go in CI.
.buildkite/pipeline.publish.yml Updates SETUP_GVM_VERSION used to install Go in CI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .go-version Outdated
@@ -1 +1 @@
1.24.2
1.25.7

Copilot AI Mar 3, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description suggests this is a backport to update the GCP Infrastructure Manager CloudShell link, but this PR also bumps the repository Go toolchain (.go-version) and CI gvm installer version. Please confirm these CI/toolchain changes are intentional for this backport; if not, consider splitting them into a separate PR to avoid unexpected CI/build impact.

Copilot uses AI. Check for mistakes.
Comment thread .go-version Outdated
@@ -1 +1 @@
1.24.2
1.25.7

Copilot AI Mar 3, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.go-version is bumped to 1.25.7, but go.mod still declares go 1.24.2 (verified in go.mod). If the repo is moving to Go 1.25, it’s better to keep these in sync (or add a note/plan for why they intentionally differ) to avoid confusion and toolchain-dependent behavior in CI and local builds.

Suggested change
1.25.7
1.24.2

Copilot uses AI. Check for mistakes.
@elasticmachine

elasticmachine commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown

💔 Build Failed

Failed CI Steps

History

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

Package google_workspace 👍(5) 💚(8) 💔(8)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
group_enterprise 4424.78 3194.89 -1229.89 (-27.8%) 💔
login 8547.01 5291.01 -3256 (-38.1%) 💔
token 3322.26 2288.33 -1033.93 (-31.12%) 💔
vault 12820.51 8064.52 -4755.99 (-37.1%) 💔
alert 4424.78 3205.13 -1219.65 (-27.56%) 💔
calendar 4464.29 3412.97 -1051.32 (-23.55%) 💔
chat 7462.69 4629.63 -2833.06 (-37.96%) 💔
device 2415.46 1552.8 -862.66 (-35.71%) 💔

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Mar 3, 2026
@mrodm
mrodm requested a review from a team March 4, 2026 09:22
mrodm
mrodm approved these changes Mar 4, 2026
View reviewed changes

@mrodm mrodm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM the changes related to .buildkite/ folder.

Added @elastic/contextual-security as a code owner of this package.

It looks like that the packages failing in CI are related to issues that were already solved in main branch.

@amirbenun amirbenun closed this Mar 4, 2026
@amirbenun

amirbenun commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

Opened a separate PR to fix the CI issue - #17655

@github-actions github-actions Bot mentioned this pull request May 7, 2026
Closed
4 tasks
This was referenced May 26, 2026
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mrodm mrodm mrodm approved these changes

Assignees

No one assigned

Labels

Integration:cloud_security_posture Security Posture Management

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amirbenun @elasticmachine @mrodm @andrewkroh