Skip to content

[QNAP]: Add support for access logs with user.domain and event logs without any associated user and ip address - #17408

Merged
taylor-swanson merged 5 commits into
elastic:mainfrom
maximilianpohle:main
Feb 24, 2026
Merged

[QNAP]: Add support for access logs with user.domain and event logs without any associated user and ip address#17408
taylor-swanson merged 5 commits into
elastic:mainfrom
maximilianpohle:main

Conversation

@maximilianpohle

@maximilianpohle maximilianpohle commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Add support for access logs with user.domain and event logs without any associated user and ip address.

Added additional sample event logs as well.

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@maximilianpohle
maximilianpohle requested a review from a team as a code owner February 13, 2026 10:09
@cla-checker-service

cla-checker-service Bot commented Feb 13, 2026 •
edited
Loading

Copy link
Copy Markdown

💚 CLA has been signed

@maximilianpohle

maximilianpohle commented Feb 13, 2026

Copy link
Copy Markdown
Contributor Author

CLA is signed.

bhapas
bhapas reviewed Feb 13, 2026
View reviewed changes

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update changelog and create a new version.

@andrewkroh andrewkroh added Integration:qnap_nas QNAP NAS (Community supported) Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Feb 13, 2026
@elasticmachine

elasticmachine commented Feb 13, 2026

Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)

@ilyannn
ilyannn self-requested a review February 13, 2026 13:39
ilyannn
ilyannn previously requested changes Feb 13, 2026
View reviewed changes

@ilyannn ilyannn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run elastic-package build and commit the updated docs/README.md

Comment thread packages/qnap_nas/data_stream/log/_dev/test/pipeline/test-access.log-expected.json
@github-actions

github-actions Bot commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

✅ Vale Linting Results

No issues found on modified lines!

The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

@bhapas

bhapas commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

/test

1 similar comment
@ilyannn

ilyannn commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

/test

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@ilyannn
ilyannn self-requested a review February 13, 2026 15:06
ilyannn
ilyannn reviewed Feb 13, 2026
View reviewed changes

@ilyannn ilyannn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any issues but will defer to others on the grok pattern

@ilyannn
ilyannn dismissed their stale review February 13, 2026 15:09

This was fixed

taylor-swanson
taylor-swanson reviewed Feb 13, 2026
View reviewed changes
Comment thread packages/qnap_nas/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Feb 13, 2026
@bhapas

bhapas commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

/test

@maximilianpohle

maximilianpohle commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

Can we merge, or are there any other issues that need to be addressed?

taylor-swanson
taylor-swanson reviewed Feb 24, 2026
View reviewed changes

@taylor-swanson taylor-swanson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me, just need to resolve the file conflicts. The version should be bumped to 1.25.2 as of writing.

As a note, elastic-package was recently upgraded and was used to regenerate the README. Make sure you are running the latest version when rebuilding the README, otherwise regressions may occur.

@maximilianpohle

maximilianpohle commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

@taylor-swanson Done

@taylor-swanson

taylor-swanson commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

elasticmachine commented Feb 24, 2026

Copy link
Copy Markdown

💚 Build Succeeded

History

@taylor-swanson
taylor-swanson merged commit 2ff4e48 into elastic:main Feb 24, 2026
9 checks passed
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Package qnap_nas - 1.25.2 containing this change is available at https://epr.elastic.co/package/qnap_nas/1.25.2/

navnit-elastic pushed a commit to navnit-elastic/integrations that referenced this pull request Mar 2, 2026
@maximilianpohle @svampohle Navnit Chauhan
[qnap_nas]: Add support for access logs with user.domain and event lo…
b011a0d 
…gs without any associated user and ip address (elastic#17408)

- Add support for access logs with user.domain and event logs without any associated user and ip address

---------

Co-authored-by: Maximilian Pohle <maximilian.pohle@sva.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilyannn ilyannn ilyannn left review comments
@bhapas bhapas bhapas left review comments
@taylor-swanson taylor-swanson taylor-swanson approved these changes
+1 more reviewer
@svampohle svampohle svampohle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:qnap_nas QNAP NAS (Community supported) Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@maximilianpohle @elasticmachine @bhapas @ilyannn @taylor-swanson @svampohle @andrewkroh