Skip to content

Fix Remove incorrect --hostfs flag documentation - #50805

Merged
Tacklebox merged 3 commits into
mainfrom
mborden/remove-hostfs-flag-documentation
May 21, 2026
Merged

Fix Remove incorrect --hostfs flag documentation#50805
Tacklebox merged 3 commits into
mainfrom
mborden/remove-hostfs-flag-documentation

Conversation

@Tacklebox

@Tacklebox Tacklebox commented May 20, 2026 •
edited by ricardoamaro
Loading

Copy link
Copy Markdown
Contributor

This PR removes a bit of misleading documentation. The --hostfs cli flag has no effect for auditbeat.

Relates to elastic/integrations#19080

@Tacklebox Tacklebox self-assigned this May 20, 2026
@Tacklebox
Tacklebox requested a review from a team as a code owner May 20, 2026 08:36
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 20, 2026
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • /test : Run the Buildkite pipeline.

@Tacklebox Tacklebox added the Team:Security-Linux Platform Linux Platform Team in Security Solution label May 20, 2026
@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented May 20, 2026

Copy link
Copy Markdown

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 20, 2026
@mergify

mergify Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @Tacklebox? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@coderabbitai

coderabbitai Bot commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: e3d8bc7a-f63b-44f1-b77a-5d8a013a9609

📥 Commits

Reviewing files that changed from the base of the PR and between 0f9036f and b70f9bd.

📒 Files selected for processing (1)
  • changelog/fragments/1779272432-remove-hostfs-cli-flag-doc.yaml
✅ Files skipped from review due to trivial changes (1)
  • changelog/fragments/1779272432-remove-hostfs-cli-flag-doc.yaml
📝 Walkthrough

Walkthrough

This PR removes documentation for the --system.hostfs MOUNT_POINT flag from the auditbeat run command reference and adds a changelog fragment (bug-fix) noting the removal; the deleted 3-line flag block causes the "Also see [Global flags]" section to follow immediately after the --memprofile FILE entry.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mborden/remove-hostfs-flag-documentation
  • 🛠️ Update Documentation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Tacklebox

Tacklebox commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

run docs-build

@github-actions

github-actions Bot commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🔍 Preview links for changed docs

@github-actions

github-actions Bot commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Vale Linting Results

No issues found on modified lines!

The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

vishaangelova
vishaangelova reviewed May 20, 2026
View reviewed changes
Comment thread changelog/fragments/1779272432-remove-hostfs-cli-flag-doc.yaml Outdated
@ricardoamaro ricardoamaro mentioned this pull request May 21, 2026
Open
1 of 5 tasks
vishaangelova
vishaangelova approved these changes May 21, 2026
View reviewed changes

@vishaangelova vishaangelova left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, adding a backport label as we’re publishing the docs from the latest minor branch (9.4).

@vishaangelova vishaangelova added the backport-9.4 Automated backport to the 9.4 branch label May 21, 2026
@Tacklebox
Tacklebox merged commit b357202 into main May 21, 2026
18 checks passed
@Tacklebox
Tacklebox deleted the mborden/remove-hostfs-flag-documentation branch May 21, 2026 13:25
@mergify mergify Bot mentioned this pull request May 21, 2026
Merged
vishaangelova pushed a commit that referenced this pull request May 22, 2026
@mergify @Tacklebox
Fix Remove incorrect --hostfs flag documentation (#50805) (#50848)
b27886f 
* This documented command line flag doesn't exist/isn't respected so the documentation is misleading

* Added changelog fragment

* Revert "Added changelog fragment"

This reverts commit b70f9bd.

(cherry picked from commit b357202)

Co-authored-by: Maxwell Borden <Tacklebox@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request May 25, 2026
Closed
1 of 6 tasks
Copilot AI mentioned this pull request Aug 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishaangelova vishaangelova vishaangelova approved these changes
@pierrehilbert pierrehilbert Awaiting requested review from pierrehilbert
+1 more reviewer
@ricardoamaro ricardoamaro ricardoamaro approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Tacklebox Tacklebox

Labels

backport-9.4 Automated backport to the 9.4 branch cleanup docs skip-changelog Team:Security-Linux Platform Linux Platform Team in Security Solution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tacklebox @ricardoamaro @pierrehilbert @vishaangelova