Fix: Return out-of-bounds index instead of -1 for activeParameter - #3580
Merged
Merged
Conversation
When there's no active parameter, return the number of parameters rather than -1 Implements what suggested at eclipse-jdtls#2434
Contributor
|
Can one of the admins verify this patch? |
This was referenced Oct 30, 2025
- Adjust tests by expecting number of parameters rather than -1
Contributor
|
add to whitelist |
Contributor
|
Works fine with vscode. Aligns with the spec, all good for me. Thanks @tartarughina! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2434.
Problem
The signature help was returning
activeParameter = -1when no parameter is active (e.g., when the cursor is at the opening parenthesis of a method call). This violates the LSP specification and breaks signature help rendering in clients like Neovim with cmp-nvim-lsp or Zed, which cannot handle negative parameter indices.Solution
Instead of returning
-1when there's no active parameter, this PR returns the number of parameters in the signature. This ensures theactiveParameterindex is always out of bounds (when no parameter should be highlighted), which adheres to the LSP spec and prevents clients from incorrectly highlighting parameters.Example
Before:
After: