Repository navigation
Fixes after OPS 985 - #9
Merged
Merged
Conversation
Owner
Author
|
This is ready for review and comment. I will leave it open for at least 10 hours, merging no earlier than Wed 10 Mar 19:00 GMT (20:00 local). |
sroet
approved these changes
Mar 10, 2021
sroet
left a comment
sroet
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, great to see the green check marks :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests here have been failing since openpathsampling/openpathsampling#985 got merged in, because now SimStore storages must have a table called
storable_functions. One of the development notebooks, notebook 5, didn't use the standard list of OPS tables and therefore didn't include that one (since it came before storable functions were developed).This PR also fixes the README badge for tests to point to GH actions.