fix: restore main window focus after closing delete confirmation - #3031
Open
arsinclair wants to merge 1 commit into
Open
arsinclair wants to merge 1 commit into
arsinclair wants to merge 1 commit into
Conversation
My earlier focus fix is still present - 3f9e3d3, but it restores focus synchronously immediately after ShowModal returns. It seems that with newer Qt6/LCL versions, native modal window closing and activation events may finish processing afterward, causing the main window to lose focus again. The solution will queue the focus restoration so it runs after the widgetset has completed closing the dialog. Bring the main window to the front first, then restore focus to the active file panel.
Author
|
Just wondering if this PR slipped off the radar. @alexx2000 @rich2014 could you take a look when you get a minute, please. Much appreciated. |
Member
|
hi, i'm not familiar with Qt and can't assess the impact of this change on other platforms, so i can't offer any opinions. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My earlier focus fix is still present - 3f9e3d3, but it restores focus synchronously immediately after ShowModal returns. It seems that with newer Qt6/LCL versions, native modal window closing and activation events may finish processing afterward, causing the main window to lose focus again.
The solution will queue the focus restoration so it runs after the widgetset has completed closing the dialog. Bring the main window to the front first, then restore focus to the active file panel.