Skip to content

Implement fallback detection of redirects for the new CDNs #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baronfel merged 5 commits into from
Dec 22, 2024
Merged

Implement fallback detection of redirects for the new CDNs #554

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6329618
Implement fallback detection of redirects for the new CDNs
baronfel Dec 20, 2024
654cfcd
Update expectations for Powershell test runs to include new domains
baronfel Dec 21, 2024
f5d3398
Apply sanitization after following redirects on the Powershell script.
baronfel Dec 21, 2024
440f968
Add direct usage of the Azure Frontdoor CNAMEs until the nice CDN ali…
baronfel Dec 21, 2024
f1d0231
Update expectations for Bash- and macOS-specific tests
baronfel Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply sanitization after following redirects on the Powershell script.
  • Loading branch information
@baronfel
baronfel committed Dec 21, 2024
commit f5d33988de977a07a48b09354abc622eef2b1052
10 changes: 5 additions & 5 deletions src/dotnet-install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,11 +1069,6 @@ function Get-AkaMSDownloadLink([string]$Channel, [string]$Quality, [bool]$Intern
return $null
}

$actualRedirectUrl = Sanitize-RedirectUrl $akaMsDownloadLink
if ($null -ne $actualRedirectUrl) {
$akaMsDownloadLink = $actualRedirectUrl
}

Say-Verbose "The redirect location retrieved: '$akaMsDownloadLink'."
# This may yet be a link to another redirection. Attempt to retrieve the page again.
$akaMsLink = $akaMsDownloadLink
Expand All @@ -1086,6 +1081,11 @@ function Get-AkaMSDownloadLink([string]$Channel, [string]$Quality, [bool]$Intern
}
elseif ((($Response.StatusCode -lt 300) -or ($Response.StatusCode -ge 400)) -and (-not [string]::IsNullOrEmpty($akaMsDownloadLink))) {
# Redirections have ended.
$actualRedirectUrl = Sanitize-RedirectUrl $akaMsDownloadLink
if ($null -ne $actualRedirectUrl) {
$akaMsDownloadLink = $actualRedirectUrl
}

return $akaMsDownloadLink
}

Expand Down