Skip to content

Remove always-on WarningWhenMultipleRecdTypeChoice language feature flag #20715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T-Gro merged 4 commits into from
Oct 9, 2026
Merged

Remove always-on WarningWhenMultipleRecdTypeChoice language feature flag #20715

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7df4dd9
Remove always-on WarningWhenMultipleRecdTypeChoice language feature flag
invalid-email-address Oct 6, 2026
8b3f4b4
Merge main and preserve all always-on feature removals
invalid-email-address Oct 8, 2026
f81824b
Merge current main and preserve all language-feature removals
invalid-email-address Oct 9, 2026
3bc9a3c
Merge latest sibling language-feature removals from main
invalid-email-address Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge latest sibling language-feature removals from main 
Preserve MatchNotAllowedForUnionCaseWithNoData and TailCall warning flag removals alongside unconditional record-choice warnings. Regenerate and verify localization with UpdateXlf.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
Copilot and Copilot committed Oct 9, 2026
commit 3bc9a3c8c6ea4597b8071bfebfdd9fd0af93d977
1 change: 0 additions & 1 deletion src/Compiler/FSComp.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1558,7 +1558,6 @@ featureWitnessPassing,"witness passing for trait constraints in F# quotations"
featureErrorOnDeprecatedRequireQualifiedAccess,"give error on deprecated access of construct with RequireQualifiedAccess attribute"
featureCSharpExtensionAttributeNotRequired,"Allow implicit Extension attribute on declaring types, modules"
featureWarningWhenCopyAndUpdateRecordChangesAllFields,"Raises warnings when an copy-and-update record expression changes all fields of a record."
featureChkNotTailRecursive,"Raises warnings if a member or function has the 'TailCall' attribute, but is not being used in a tail recursive way."
featurePreferExtensionMethodOverPlainProperty,"prefer extension method over plain property"
featureWarningIndexedPropertiesGetSetSameType,"Indexed properties getter and setter must have the same type"
featureChkTailCallAttrOnNonRec,"Raises warnings if the 'TailCall' attribute is used on non-recursive functions."
Expand Down
3 changes: 0 additions & 3 deletions src/Compiler/Facilities/LanguageFeatures.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ type LanguageFeature =
| ErrorOnDeprecatedRequireQualifiedAccess
| CSharpExtensionAttributeNotRequired
| WarningWhenCopyAndUpdateRecordChangesAllFields
| WarningWhenTailRecAttributeButNonTailRecUsage
| UnmanagedConstraintCsharpInterop
| ReuseSameFieldsInStructUnions
| PreferExtensionMethodOverPlainProperty
Expand Down Expand Up @@ -125,7 +124,6 @@ type LanguageVersion(versionText, ?disabledFeaturesArray: LanguageFeature array)
// F# 8.0
LanguageFeature.CSharpExtensionAttributeNotRequired, languageVersion80
LanguageFeature.WarningWhenCopyAndUpdateRecordChangesAllFields, languageVersion80
LanguageFeature.WarningWhenTailRecAttributeButNonTailRecUsage, languageVersion80

// F# 9.0
LanguageFeature.NullnessChecking, languageVersion90
Expand Down Expand Up @@ -287,7 +285,6 @@ type LanguageVersion(versionText, ?disabledFeaturesArray: LanguageFeature array)
| LanguageFeature.CSharpExtensionAttributeNotRequired -> FSComp.SR.featureCSharpExtensionAttributeNotRequired ()
| LanguageFeature.WarningWhenCopyAndUpdateRecordChangesAllFields ->
FSComp.SR.featureWarningWhenCopyAndUpdateRecordChangesAllFields ()
| LanguageFeature.WarningWhenTailRecAttributeButNonTailRecUsage -> FSComp.SR.featureChkNotTailRecursive ()
| LanguageFeature.UnmanagedConstraintCsharpInterop -> FSComp.SR.featureUnmanagedConstraintCsharpInterop ()
| LanguageFeature.ReuseSameFieldsInStructUnions -> FSComp.SR.featureReuseSameFieldsInStructUnions ()
| LanguageFeature.PreferExtensionMethodOverPlainProperty -> FSComp.SR.featurePreferExtensionMethodOverPlainProperty ()
Expand Down
1 change: 0 additions & 1 deletion src/Compiler/Facilities/LanguageFeatures.fsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ type LanguageFeature =
| ErrorOnDeprecatedRequireQualifiedAccess
| CSharpExtensionAttributeNotRequired
| WarningWhenCopyAndUpdateRecordChangesAllFields
| WarningWhenTailRecAttributeButNonTailRecUsage
| UnmanagedConstraintCsharpInterop
| ReuseSameFieldsInStructUnions
/// RFC-1137
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.