Repository navigation
Remove always-on ExtendedFixedBindings language feature flag - #20429
Merged
Merged
Conversation
The ExtendedFixedBindings feature shipped in F# 8.0, the minimum accepted --langversion, so its flag can never be disabled and is dead configuration. Remove the LanguageFeature case, its feature-map entry, GetFeatureString arm, and FSComp resource string, and collapse both guarded paths in TcAndBuildFixedExpr to their always-on behaviour. Regenerated xlf files. Fixes #20194 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
T-Gro
added
the
NO_RELEASE_NOTES
T-Gro
enabled auto-merge (squash)
September 3, 2026 12:58
T-Gro
added
NO_RELEASE_NOTES
abonie
approved these changes
Sep 4, 2026
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
This was referenced Sep 4, 2026
bartelink
pushed a commit
to bartelink/fsharp
that referenced
this pull request
Oct 7, 2026
…20429) The ExtendedFixedBindings feature shipped in F# 8.0, the minimum accepted --langversion, so its flag can never be disabled and is dead configuration. Remove the LanguageFeature case, its feature-map entry, GetFeatureString arm, and FSComp resource string, and collapse both guarded paths in TcAndBuildFixedExpr to their always-on behaviour. Regenerated xlf files. Fixes dotnet#20194 Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20194
ExtendedFixedBindingsshipped in F# 8.0, the minimum accepted--langversion, so its flag could never be turned off. Removed the dead feature flag and collapsed the guarded paths inTcAndBuildFixedExprto their always-on behaviour.--disableLanguageFeature:ExtendedFixedBindingsis no longer a recognised feature name.