Skip to content

chore(Test): Inhibit RunSynchronouslyImmediate; reduce suite concurrency re #20306 #20308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T-Gro merged 12 commits into from
Aug 24, 2026
Merged

chore(Test): Inhibit RunSynchronouslyImmediate; reduce suite concurrency re #20306 #20308

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6f42291
chore(Test): Inhibit RunSynchronouslyImmedate; reduce suite concurrency
bartelink Aug 21, 2026
153fdb4
chore(Tests): Extend timeout to 30s for CI/heavy load
bartelink Aug 21, 2026
55e0fb4
chore(Build hang triage): Rule out more RSI suspects
bartelink Aug 21, 2026
9fc39e7
fix: formatting
bartelink Aug 21, 2026
ef40c5f
doc: Clarify test collection
bartelink Aug 21, 2026
6abcd1b
cleanup: Remove XUNIT_EXTRAS straggler reference
bartelink Aug 21, 2026
973bc15
refactor: Replace RunTestCasesInSequence with comments
bartelink Aug 21, 2026
0fb4bd5
refactor(RunTestCasesInSequenceAttribute): replace with DisableParall…
bartelink Aug 21, 2026
bab7105
fix: Remove warning build break
bartelink Aug 21, 2026
b1aff55
Roll back compiler temp RunSynchronously use
bartelink Aug 21, 2026
0548a8b
straggler RunTestCasesInSequence -> DisableParallization migrations
bartelink Aug 21, 2026
e841bef
chore(Tests): Reinstate RunSynchronouslyImmediate usage
bartelink Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
straggler RunTestCasesInSequence -> DisableParallization migrations
  • Loading branch information
@bartelink
bartelink committed Aug 21, 2026
commit 0548a8b4e66daa01e620628a855def189b597eba
6 changes: 3 additions & 3 deletions tests/FSharp.Compiler.Service.Tests/ProjectAnalysisTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3828,7 +3828,7 @@ let ``GetDeclarationLocation on a provided-ctor without DefinitionLocationAttrib
| FindDeclResult.ExternalDecl _ ->
failwith "expected DeclFound for provided-ctor `T()`, got ExternalDecl"

[<Fact>]
[<Fact4(DisableParallelization = true)>] // Inhibit shared usage of Project25.checker module state
let ``GetDeclarationLocation on a provided-ctor invoked through the original provided name returns DeclFound (regression #5538)`` () =
let wholeProjectResults =
Project25.checker.ParseAndCheckProject(Project25.options.Value)
Expand Down Expand Up @@ -3865,7 +3865,7 @@ let ``GetDeclarationLocation on a provided-ctor invoked through the original pro
| FindDeclResult.ExternalDecl _ ->
failwith "expected DeclFound for provided-ctor `MyType()`, got ExternalDecl"

[<Fact>]
[<Fact4(DisableParallelization = true)>] // Inhibit shared usage of Project25.checker module state
let ``Test Project25 symbol uses of type-provided types`` () =
let wholeProjectResults = Project25.checker.ParseAndCheckProject(Project25.options.Value) |> Async.RunSynchronouslyImmediate

Expand All @@ -3888,7 +3888,7 @@ let ``Test Project25 symbol uses of type-provided types`` () =
("file1", ((5, 8), (5, 9))) // line 5: let _ = >T<() (T resolves to MyType)
("file1", ((10, 8), (10, 14))) |] // line 10: let _ = >MyType<()

[<Fact>]
[<Fact4(DisableParallelization = true)>] // Inhibit shared usage of Project25.checker module state
let ``Test Project25 symbol uses of fully-qualified records`` () =
let wholeProjectResults = Project25.checker.ParseAndCheckProject(Project25.options.Value) |> Async.RunSynchronouslyImmediate

Expand Down
Loading