Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
9e37b2c
Add regression test for #6750: Mutually recursive DU values initializ…
T-Gro Mar 24, 2026
1cd0ca0
Add regression tests for #14308 and #14310: Signature generation impr…
T-Gro Mar 24, 2026
5ee6d09
Add regression test for #16410: no spurious FS3570 with KeyValue acti…
T-Gro Mar 24, 2026
632a0ab
Add regression test for #3841: Hash directive indentation in nested m…
T-Gro Mar 24, 2026
fb1ca7e
Add regression test for #14152: nowarn directive before module declar…
T-Gro Mar 25, 2026
0db49dd
Add regression test: #6929, Literal bindings preserve units of measur…
T-Gro Mar 25, 2026
251aaf2
Add regression test: #3660, array of functions invocation correctness…
T-Gro Mar 25, 2026
a02a655
Infra: Update gh aw (#19495)
T-Gro Mar 26, 2026
880dda8
Fix CLIEvent properties to be recognized as events in Symbol API (#18…
Copilot Mar 26, 2026
2292274
Add regression test: #12067, signature generation preserves FSharp. p…
T-Gro Mar 26, 2026
f647072
Add regression test for #11331: accessibility error for internal type…
T-Gro Mar 26, 2026
1dafcf3
Add regression test for #14216: No FS2303 warning for DU in FSI (#19465)
T-Gro Mar 26, 2026
cbab748
Add regression test for #13697: typeof in attribute should report FS0…
T-Gro Mar 26, 2026
01fe483
Add regression test for #9382: SRTP stress test with matrix inverse (…
T-Gro Mar 26, 2026
a21c12f
Add regression test: #12023, FSI can load System.Drawing.Common via n…
T-Gro Mar 26, 2026
63294d7
Add documentation and tests that maxBy/minBy return the first max/min…
Copilot Mar 27, 2026
0b80769
Bugfix :: Fix type definition metadata: duplicate methods, event flag…
T-Gro Mar 27, 2026
a0cce49
resolve integrity issues in gh aw (#19510)
T-Gro Mar 27, 2026
0c868a5
Add Regression PR Shepherd workflow (#19500)
T-Gro Mar 30, 2026
2adf45d
Improve repo-assist: regression test verification, windows-only revis…
T-Gro Mar 30, 2026
bf62ec0
Update dependencies from https://github.com/dotnet/arcade build 20260…
dotnet-maestro[bot] Mar 30, 2026
df38aef
[main] Update dependencies from dotnet/msbuild (#19493)
dotnet-maestro[bot] Mar 30, 2026
358d088
Add regression test for #3532: FSharpEntity.IsByRef is false for byre…
T-Gro Mar 30, 2026
3ee2a3e
Add regression test for #15655: error codes 999 and 3217 are distinct…
T-Gro Mar 30, 2026
f540da5
Add regression test: #13519, C# optional parameters from F# (#19473)
T-Gro Mar 30, 2026
68fb63d
Add regression test: #6648, DU of DUs with inline static members (#19…
T-Gro Mar 31, 2026
f3b6407
Fix repo-assist: add safe output discipline and iteration limits (#19…
Copilot Mar 31, 2026
7d031d3
Update dependencies from https://github.com/dotnet/msbuild build 2026…
dotnet-maestro[bot] Mar 31, 2026
b0bb2f0
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-maestro[bot] Mar 31, 2026
8254128
Add aw-auto-update workflow + upgrade to v0.64.4 (#19519)
T-Gro Mar 31, 2026
1775f42
Add regression test for #6715: land is a valid identifier (#19478)
T-Gro Mar 31, 2026
4e25902
[main] Update dependencies from dotnet/roslyn (#19494)
dotnet-maestro[bot] Apr 1, 2026
4b57615
Add regression test: #15987, SRTP overload resolution returns correct…
github-actions[bot] Apr 1, 2026
af3a8eb
Add regression test: #15070, hash-load with dot-slash prefix no longe…
github-actions[bot] Apr 1, 2026
7e0ab7a
Add regression test: #16056, auto property DeclarationLocation correc…
github-actions[bot] Apr 1, 2026
af6c784
Add regression test: #19456, nested let bang in plain let inside task…
github-actions[bot] Apr 1, 2026
02b1081
Add regression test: #16007, SRTP ctor constraint no longer causes va…
github-actions[bot] Apr 1, 2026
9b016f5
Add regression test: #7177, never-matched warning with active pattern…
github-actions[bot] Apr 1, 2026
7580b31
Tests: prevent in-proc fsi from killing test host with "exit" (#19407)
majocha Apr 1, 2026
3550f3c
Add regression test: #9878, SRTP with phantom type parameter (#19467)
T-Gro Apr 1, 2026
6a5df48
Fix FS0452 for empty string pattern matching in quotations (#19532)
Copilot Apr 1, 2026
599a99f
Fix regression-pr-shepherd: bound PR processing per run to prevent co…
Copilot Apr 1, 2026
d507366
Make fsharp-diagnostics skill a directive, not a suggestion (#19520)
T-Gro Apr 1, 2026
d85a74c
Update agentic workflows to v0.67.2 and fix merge conflict (#19556)
T-Gro Apr 8, 2026
6f0e1ed
Fix Regression PR Shepherd: restrict push scope and strengthen PR sel…
Copilot Apr 9, 2026
1f46886
[main] Source code updates from dotnet/dotnet (#19546)
dotnet-maestro[bot] Apr 9, 2026
a88269a
[main] Update dependencies from dotnet/roslyn (#19544)
dotnet-maestro[bot] Apr 10, 2026
85d7cb1
[main] Update dependencies from dotnet/msbuild (#19543)
dotnet-maestro[bot] Apr 10, 2026
0539af7
Add regression test: #16154, task CE with IQueryable filters no longe…
github-actions[bot] Apr 10, 2026
ead77d1
[main] Update dependencies from dotnet/arcade (#19542)
dotnet-maestro[bot] Apr 10, 2026
98c4774
Add regression tests for #10043: backtick, @, and ! in type annotatio…
T-Gro Apr 10, 2026
5bcca43
Fix wrong warning 20 range in sequential expressions (#5735) (#19504)
Copilot Apr 11, 2026
bd2823e
Fix completion inconsistently filtering obsolete fields and events (#…
Copilot Apr 11, 2026
f1b1a57
Map this branch to rel/insiders, set VSMinorVersion=7
abonie May 6, 2026
dba9a97
Merge branch 'release/dev18.6' into release/dev18.6
abonie May 7, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add regression test for #3841: Hash directive indentation in nested m…
…odule (#19489)

Verify that a hash directive (#r) at column 0 inside a nested module
produces FS0058 indentation error with F# 8 strict indentation rules.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
T-Gro and Copilot authored Mar 24, 2026
commit 632a0ab8daf07f3a331a01b3469c693444367f46
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,28 @@ module ``Test Compiler Directives`` =
|> shouldFail
|> withSingleDiagnostic (Warning 213, Line 2, Col 1, Line 2, Col 10, "'' is not a valid assembly name")

// https://github.com/dotnet/fsharp/issues/3841
[<Fact>]
let ``Hash directive inside nested module produces indentation error`` () =
Fsx
"""
let x = 42

module Nested =
let foo = 123

#r "SomeAssembly"

let bar = 1

let y = x
"""
|> withLangVersion80
|> compile
|> shouldFail
|> withSingleDiagnostic
(Error 58, Line 11, Col 1, Line 11, Col 4, "Unexpected syntax or possible incorrect indentation: this token is offside of context started at position (9:5). Try indenting this further.\nTo continue using non-conforming indentation, pass the '--strict-indentation-' flag to the compiler, or set the language version to F# 7.")

module ``Test compiler directives in FSI`` =
[<Fact>]
let ``r# "" is invalid`` () =
Expand Down
Loading