Key temporal table map removals by the raw schema in SqlServerMigrationsSqlGenerator - #39099
Merged
AndriySvyryd merged 1 commit intoOct 2, 2026
Conversation
…onsSqlGenerator
RewriteOperations tracks temporal information per table in a dictionary keyed by the table name and the schema exactly as written on the migration operation (which may be null). Every insert and lookup used that raw schema, but the two Remove calls in the DropTable and RenameTable branches used the schema defaulted from the model.
When a temporal table is renamed from a null schema into the model's default schema (for example after adding HasDefaultSchema("dbo") to a model with a temporal table), the entry added under the new name was removed immediately, and the following AlterTable operation on the same table threw KeyNotFoundException.
Use the raw schema for the removals so they match the keys that were inserted.
Fixes dotnet#38601
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues; the fix includes regression coverage.
Review effort: Lite
Findings: None
What changed in this PR
Fixes SQL Server temporal migration failures caused by inconsistent schema keys.
Changes:
- Uses raw schemas for temporal map removals.
- Adds regression coverage for schema moves.
| File | Summary |
|---|---|
test/EFCore.SqlServer.FunctionalTests/Migrations/SqlServerMigrationsSqlGeneratorTest.cs |
Adds regression coverage for issue #38601. |
src/EFCore.SqlServer/Migrations/SqlServerMigrationsSqlGenerator.cs |
Corrects temporal map removal keys. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
AndriySvyryd
approved these changes
Oct 2, 2026
AndriySvyryd
left a comment
AndriySvyryd
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RewriteOperations tracks temporal information per table in a dictionary keyed by the table name and the schema exactly as written on the migration operation (which may be null). Every insert and lookup used that raw schema, but the two Remove calls in the DropTable and RenameTable branches used the schema defaulted from the model.
When a temporal table is renamed from a null schema into the model's default schema (for example after adding HasDefaultSchema("dbo") to a model with a temporal table), the entry added under the new name was removed immediately, and the following AlterTable operation on the same table threw KeyNotFoundException.
Use the raw schema for the removals so they match the keys that were inserted.
Fixes #38601