This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
Use the identified python when building System.Private.CoreLib - #19043
Merged
Merged
Conversation
build.sh and build.cmd contain logic to identify a working version of python to use. System.Private.CoreLib ignores that and directly invokes 'python', which may not work, or even execute a different program.
omajid
force-pushed
the
use-identified-python
branch
from
July 19, 2018 21:57
7a8d1dd to
21e04d9
Compare
Member
Author
|
For the motivation behind this change, see python/peps#630 Essentially, it is now going to be possible to only have the commands |
Member
Author
|
Adding some folks who have touched these files in the past to cc. Can someone please take a look? Thanks. |
jkotas
approved these changes
Aug 1, 2018
Member
Author
|
Thanks for reviewing and merging! |
This was referenced Aug 9, 2018
omajid
added a commit
to omajid/dotnet-coreclr
that referenced
this pull request
Aug 24, 2020
This is a combined fix from 3 different PRs and one additional fix for 2.1: - dotnet#19043 - dotnet#19356 - dotnet#22145 The 2.1-specific fix is that python is is only used as a fallback, in case all other python program names dont work. As for the original PRs, they perform these changes: build.sh and build.cmd contain logic to identify a working version of python to use. System.Private.CoreLib ignores that and directly invokes 'python', which may not work, or even execute a different program. Fix that. The windows build scripts try finding python in order of python3, python2 and then python. The unix build scripts dont. They just try python2 variants and then fail. This change makes brings them closer together by letting users build using only python3. Use the same logic in CMakeLists.txt that's used in build.sh/build.cmd to lookup python.
Anipik
pushed a commit
that referenced
this pull request
Sep 18, 2020
This is a combined fix from 3 different PRs and one additional fix for 2.1: - #19043 - #19356 - #22145 The 2.1-specific fix is that python is is only used as a fallback, in case all other python program names dont work. As for the original PRs, they perform these changes: build.sh and build.cmd contain logic to identify a working version of python to use. System.Private.CoreLib ignores that and directly invokes 'python', which may not work, or even execute a different program. Fix that. The windows build scripts try finding python in order of python3, python2 and then python. The unix build scripts dont. They just try python2 variants and then fail. This change makes brings them closer together by letting users build using only python3. Use the same logic in CMakeLists.txt that's used in build.sh/build.cmd to lookup python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.shandbuild.cmdcontain logic to identify a working version of python to use.System.Private.CoreLibignores that and directly invokes 'python', which may not work, or even execute a different program.