Skip to content

Import official Android.Media.Quality first-fill documentation - #813

Open
jonathanpeppers wants to merge 4 commits into
mainfrom
jonathanpeppers-import-android-media-quality-documentati
Open

jonathanpeppers wants to merge 4 commits into
mainfrom
jonathanpeppers-import-android-media-quality-documentati

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Tracks #153.

Documentation scope

Import 130 substantive first fills from 22 official Android developer-reference pages into 20 API XML files, using 13 individually reviewed offline batches capped at ten changes. Every production apply includes both docs\xml\Android.Media.Quality and docs\xml\ns-Android.Media.Quality.xml, plus the namespace. Existing nonplaceholder channels and XML outside Docs remain byte-identical; generated indexes and other namespaces are untouched.

The current whole-scope direct Docs leaf placeholder balance is 523 → 393: API 521 → 391, overview 2 → 2. The overview is scanned but its Name-only root is not selected by the existing namespace FullName filter; it remains unchanged. These structural counts are distinct from the issue's historical raw-text count.

Conservative source guards

Withhold 19 exact unsafe channels across 11 owners: eight parcel summary/remarks pairs containing Flatten this object in to a Parcel., two collection returns describing a single nullable profile, and one parameter-type value advertising combinations of mutually exclusive codes. Full official declarations, source identity, managed DocId/signature/ordered parameters/return and JNI identity bind each guard. Safe sibling channels remain usable through a direct first-fill-only path; authored or nested documentation is not repaired or enriched.

The complete final report records zero candidates/errors and 623 skipped entries: 223 missing member registrations, 46 missing type registrations, 19 ambiguous source channels, 37 nonmeaningful channels, 41 empty source documents, 1 missing parameter, 232 already-current remarks, 2 missing remarks, 20 missing returns and 2 missing summaries. Report entries are not a count of remaining placeholders.

Qualification

The ordinary full registered suite passed before changes and at the exact published head using default JIT dotnet run --no-cache -p:PublishAot=false tools\importer.cs -- --self-test. New tests retain complete original contiguous native declaration fragments and exercise real bounded production applies, zero-write repeats, identity/signature controls and authored/nested preservation. All inherited tests, fixtures, guide content and optional record fields are preserved.

A fresh initially empty own-cache online/offline pair differs only in three transport JSON fields and the TXT cache line. A real final offline apply records zero writes/errors with unchanged whole scope/tool bytes. Every authored channel is tied to an independently reviewed complete native source fragment; all 130 fragments compare byte-for-byte against the fresh sources. XML parsing and git diff --check pass. The independent complete binary inverse reconstructs the entire actual-main path/mode/blob tree (11,140 paths); the new fixture accounts for the proposed tree's 11,141 paths.

Original failures and limitations are retained: guard-test reader/setup failures precede the passing full suite; one concurrent offline evidence after-snapshot failed on disappearing self-test temporary files and has no retrospective native receipt; a separate serialized offline receipt is qualified. The first failed guard-suite snapshot omitted the then-untracked new fixture; later complete scopes include it. A pagination-reader assertion was corrected without changing or rerunning its original API payload. Fresh validation and fixtures are not a historical legacy-output baseline.

Import 130 exact, meaningful official Android documentation channels in
13 bounded offline batches, preserving existing authored documentation.
Withhold 19 source-bound unsafe parcel, collection-return and type-code
channels while retaining their safe direct placeholder siblings.
Add full native-fragment production guards and registered proof fixtures.

Tracks #153.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 2, 2026 02:42
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@jonathanpeppers
jonathanpeppers enabled auto-merge (squash) October 2, 2026 02:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The broad source import and specialized guard logic warrant final human provenance review despite extensive tests.

Review effort: Balanced
Findings: None

What changed in this PR

Imports 130 official Android.Media.Quality documentation fills while preserving unsafe or authored channels.

Changes:

  • Adds source-bound guards for 19 unsafe documentation channels.
  • Adds comprehensive self-test fixtures for guarded imports.
  • Updates 20 API XML files with official documentation.
File Description
tools/​importer.md Documents Quality-specific safeguards.
tools/​importer.cs Implements guards, declaration parsing, and tests.
tools/​importer-fixtures/​quality-firstfill-native.json Adds native-source guard fixtures.
docs/​xml/​Android.Media.Quality/​ActiveProcessingPicture.xml Documents Parcelable members.
docs/​xml/​Android.Media.Quality/​AmbientBacklightEvent.xml Documents event and Parcelable members.
docs/​xml/​Android.Media.Quality/​AmbientBacklightEventType.xml Documents event enum values.
docs/​xml/​Android.Media.Quality/​AmbientBacklightMetadata.xml Documents metadata values and members.
docs/​xml/​Android.Media.Quality/​AmbientBacklightMetadataAlgorithm.xml Documents algorithm enum values.
docs/​xml/​Android.Media.Quality/​AmbientBacklightSettings.xml Documents settings values and members.
docs/​xml/​Android.Media.Quality/​AmbientBacklightSettingsSource.xml Documents source enum values.
docs/​xml/​Android.Media.Quality/​MediaQualityManager.xml Documents profile queries and callbacks.
docs/​xml/​Android.Media.Quality/​MediaQualityManager+ProfileQueryParams.xml Documents query Parcelable members.
docs/​xml/​Android.Media.Quality/​MediaQualityManager+ProfileQueryParams+Builder.xml Documents builder operations.
docs/​xml/​Android.Media.Quality/​ParameterCapability.xml Documents capability members.
docs/​xml/​Android.Media.Quality/​ParameterCapabilityType.xml Documents parameter-type values.
docs/​xml/​Android.Media.Quality/​PictureProfile.xml Documents picture-profile members.
docs/​xml/​Android.Media.Quality/​PictureProfile+Builder.xml Documents parameter configuration.
docs/​xml/​Android.Media.Quality/​PictureProfileErrorType.xml Documents picture-profile errors.
docs/​xml/​Android.Media.Quality/​PictureProfileType.xml Documents picture-profile types.
docs/​xml/​Android.Media.Quality/​SoundProfile.xml Documents sound-profile members.
docs/​xml/​Android.Media.Quality/​SoundProfile+Builder.xml Documents parameter configuration.
docs/​xml/​Android.Media.Quality/​SoundProfileErrorType.xml Documents sound-profile errors.
docs/​xml/​Android.Media.Quality/​SoundProfileType.xml Documents sound-profile types.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

jonathanpeppers and others added 2 commits October 2, 2026 03:56
Integrate the protected Controls Templates and Media Browse additions while
retaining all Quality first-fill channels, registered tests and source fixtures.
Resolve the independent production branches and optional source-record tails
without changing the existing review round.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Integrate the protected NFC CardEmulators additions while retaining all Quality
documentation, complete NFC/Browse/Controls/TV production paths, registered
ordinary tests, independent source fixtures, optional fields and guide content.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants