Import verified Android.Service.Chooser documentation - #812
Open
jonathanpeppers wants to merge 3 commits into
Open
jonathanpeppers wants to merge 3 commits into
jonathanpeppers wants to merge 3 commits into
Conversation
Guard the exact stale removeStateListener source description and preserve authored contracts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@dalexsoto review |
jonathanpeppers
enabled auto-merge (squash)
October 1, 2026 23:42
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The imports follow established conventions, preserve unresolved channels, and include comprehensive regression coverage for the new safety guard.
Review effort: Balanced
Findings: None
What changed in this PR
Imports verified Android reference documentation for Android.Service.Chooser while safely excluding a known incorrect listener description.
Changes:
- Replaces 47 documentation placeholders across 10 API XML files.
- Adds an exact binding/source guard for stale
RemoveStateListenerprose. - Adds fixture-based importer regression coverage and guidance.
| File | Description |
|---|---|
tools/importer.md |
Documents the Chooser safety guard. |
tools/importer.cs |
Implements and tests the guarded mapping. |
tools/importer-fixtures/chooser-listener.xml |
Adds the managed binding fixture. |
tools/importer-fixtures/chooser-listener.html |
Adds the stale-source fixture. |
ChooserTargetService.xml |
Documents OnBind. |
ChooserTarget.xml |
Documents construction and parceling. |
ChooserSessionToken.xml |
Documents parceling members. |
ChooserSessionState.xml |
Documents session-state values. |
ChooserSession+IStateListener.xml |
Documents the state parameter. |
ChooserSession.xml |
Adds listener guidance and metadata. |
ChooserResultValue.xml |
Documents chooser-result values. |
ChooserResult.xml |
Documents parceling members. |
ChooserAction+Builder.xml |
Documents builder construction. |
ChooserAction.xml |
Documents parceling members. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Preserve complete Chooser, Browse, Controls, TV and independent source/test/fixture contracts. Validate the exact resolved tree with the authorized complete private ordinary snapshot. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Retain all independent source, guide, fixture and regression bodies; qualify the exact resolved tree with its complete authorized private ordinary suite. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@dalexsoto review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks #175
Imports 46 substantive documentation channels from exact official Android reference matches across 10 Chooser XML files, plus one metadata-only placeholder removal. Whole direct-Docs placeholders, including the namespace overview, decrease from 193 to 146. Existing authored documentation, JNI/API metadata, availability, nullability, attribution, references, and byte conventions are preserved.
Adds an exact source-and-binding guard for
ChooserSession.removeStateListener(StateListener), whose current official description incorrectly namesUpdateListener. That ambiguous mapping remains unchanged; no replacement prose is inferred. Regression coverage exercises production first fills, atomic budgets, corrected/removed source eligibility, prior importer-owned Docs, raw authored/mixed layouts, and provenance/binding negatives.ChooserTargetService.OnBindwas separately verified against the pinned implementation; its legitimate nullable-binder contract is retained.The full ordinary unfiltered importer self-test passes on commit
244754e25c5273699292053b8fa330e12fc16d4d. A new empty-cache online/offline pair matches losslessly except transport counters; all 58 declared detail sections and the additional contract sections match the initial audited sources. The real bounded offline repeat applies zero changes/files/errors, with the entire tracked physical inventory unchanged. The cumulative binary inverse recovers the entire current-main tree6ad22ca3954fcb37376b1a11270cd3f7227a9d7eexactly. The full documentation publisher was not run locally.