Import verified Android.Health.Connect.ChangeLog documentation - #809
Open
jonathanpeppers wants to merge 1 commit into
Open
jonathanpeppers wants to merge 1 commit into
jonathanpeppers wants to merge 1 commit into
Conversation
Fill eligible declared Android reference channels and conservatively withhold the contradicted DataOrigin parameter with registered production regressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@dalexsoto review |
jonathanpeppers
enabled auto-merge (squash)
October 1, 2026 23:11
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No blocking issues remain in the scoped imports or guarded importer changes; the full publishing build remains unverified locally.
Review effort: Balanced
Findings: None
What changed in this PR
Partially addresses #101 by importing verified Android reference documentation into Android.Health.Connect.ChangeLog, preserving authored content and API metadata.
Changes:
- Fills 48 substantive documentation channels across eight XML files.
- Adds an exact-match guard for contradicted
DataOriginparameter documentation. - Adds regression coverage for preservation, withdrawal, corrected sources, and zero-write repeats.
| File | Description |
|---|---|
| tools/importer.md | Documents the new source exclusion. |
| tools/importer.cs | Adds the guard and registered regression tests. |
| tools/importer-fixtures/changelog-token-builder-android-reference.html | Supplies the official-source test fixture. |
| docs/xml/Android.Health.Connect.ChangeLog/ChangeLogTokenResponse.xml | Documents Parcelable behavior. |
| docs/xml/Android.Health.Connect.ChangeLog/ChangeLogTokenRequest+Builder.xml | Documents type selection and mutual exclusivity. |
| docs/xml/Android.Health.Connect.ChangeLog/ChangeLogTokenRequest.xml | Documents medical resource types and parceling. |
| docs/xml/Android.Health.Connect.ChangeLog/ChangeLogsResponse+DeletedMedicalResource.xml | Documents construction and deletion details. |
| docs/xml/Android.Health.Connect.ChangeLog/ChangeLogsResponse+DeletedLog.xml | Adds deprecated-constructor replacement guidance. |
| docs/xml/Android.Health.Connect.ChangeLog/ChangeLogsResponse.xml | Documents medical resource results and parceling. |
| docs/xml/Android.Health.Connect.ChangeLog/ChangeLogsRequest+Builder.xml | Documents page-size limits. |
| docs/xml/Android.Health.Connect.ChangeLog/ChangeLogsRequest.xml | Documents page-size values and parceling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
@dalexsoto review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks #101
Coverage
This is a partial-coverage update, not completion of the namespace issue. The complete namespace audit covered 12 XML files and eight declared official Android reference pages. Thirteen reviewed, bounded offline importer batches filled 48 substantive documentation channels across eight XML files. One additional remarks placeholder was replaced with source-reference/attribution metadata only. Direct
<Docs>placeholder channels, counting the namespace overview once, decreased from 194 to 145.Imported channels cover medical/record type selection and their mutual exclusivity, medical resource getters and deletion details, conditional Parcelable contents and write flags, page-size limits, and the deprecated deletion constructor's replacement guidance. Existing authored prose, references/attribution, binding/API metadata (including Android 36.1 availability), BOM/newlines, generated files, and unrelated documentation remain unchanged.
Conservative source handling
The official
ChangeLogTokenRequest.Builder.addDataOriginFilter(DataOrigin)parameter calls its singleDataOriginargument a “list of package names.” Its exact registered SDK contract and pinned implementation establish that it adds one origin to a set. The importer now withholds that complete contradicted channel rather than inventing replacement prose. The narrowly scoped guard requires the full original source contract, canonical URL/label, managed signature/types, and exact JNI registration.Registered production regressions cover max-one first fills, withdrawal of actual production-generated prior importer markup, strict authored/mixed/provenance/API negatives, future corrected or removed wording, and persisted zero-write repeats. Existing independent regression assertions remain intact. Implementation excerpts verify the contradiction only; no AOSP prose fallback is imported.
Remaining placeholders are conservatively retained for absent registrations, absent/empty declared channels, type/nullability-only text, and the contradicted parameter. Final skip entries also include already-current imported remarks; they are not a remaining-placeholder count. Official parcel typography is preserved verbatim rather than generally corrected.
Validation and qualification
git diff --checkis clean.--max-changes 10 --applyrepeat performed zero operations, zero writes, and zero errors.Base:
855613e7c309d2a1f829f70f5a32e2bcd6da1d4b. Initial reviewed head:c5b9f78c0184f474cfe3ee62b7803047d3603c2e.