do not throw directly, use throw helper

otac0n · May 28, 2025 · May 28, 2025 · May 28, 2025 · May 28, 2025 · May 28, 2025
commit 9410cc5db3884c770a1620b86b06a7862fff2aeb
@@ -23,4 +23,4 @@
     <WeaveTemplate Include="Templates\VectorExt.weave" />
     <None Remove="Matrix.weave" />
   </ItemGroup>
-</Project>
+</Project>
@@ -7,7 +7,7 @@ namespace GenerateMatrixMath
 {
     internal static class RoslynExtensions
     {
-        public static string ToCSharpString(this Type type, string[] usingNamespaces = null, Assembly[] usingAssemblies = null, SymbolDisplayFormat symbolDisplayFormat = null)
+        public static string ToCSharpString(this Type type, string[]? usingNamespaces = null, Assembly[]? usingAssemblies = null, SymbolDisplayFormat? symbolDisplayFormat = null)
         {
             var compilationUnit = SyntaxFactory.CompilationUnit();
             if (usingNamespaces != null)
@@ -21,19 +21,21 @@ public static string ToCSharpString(this Type type, string[] usingNamespaces = n
                     SyntaxFactory.UsingDirective(SyntaxFactory.IdentifierName("System")));
             }
 
+#pragma warning disable IL3000
             MetadataReference[] metadataReferences;
             if (usingAssemblies != null)
             {
-                metadataReferences = Array.ConvertAll(usingAssemblies, u => MetadataReference.CreateFromFile(u.Location));
+                metadataReferences =
+                    Array.ConvertAll(usingAssemblies, u => MetadataReference.CreateFromFile(u.Location));
             }
             else
             {
-                metadataReferences = new[]
-                {
-                MetadataReference.CreateFromFile(typeof(object).Assembly.Location),
-                MetadataReference.CreateFromFile(type.Assembly.Location)
-            };
+                metadataReferences = new[] {
+                    MetadataReference.CreateFromFile(typeof(object).Assembly.Location),
+                    MetadataReference.CreateFromFile(type.Assembly.Location)
+                };
             }
+#pragma warning restore IL3000
 
             var typeName = SyntaxFactory.ParseTypeName(type.ToFullyQualifiedName());
 
@@ -43,8 +45,8 @@ public static string ToCSharpString(this Type type, string[] usingNamespaces = n
                         SyntaxFactory.VariableDeclarator(
                             SyntaxFactory.Identifier("field")))));
             compilationUnit = compilationUnit.AddMembers(
-                SyntaxFactory.ClassDeclaration("MyClass").AddMembers(
-                    field))
+                    SyntaxFactory.ClassDeclaration("MyClass").AddMembers(
+                        field))
                 .NormalizeWhitespace();
 
             var tree = compilationUnit.SyntaxTree;
@@ -57,7 +59,7 @@ public static string ToCSharpString(this Type type, string[] usingNamespaces = n
                 .Members.OfType<FieldDeclarationSyntax>().Single()
                 .Declaration.Type);
 
-            return typeSymbol.Type.ToDisplayString(symbolDisplayFormat ?? new SymbolDisplayFormat(
+            return typeSymbol.Type!.ToDisplayString(symbolDisplayFormat ?? new SymbolDisplayFormat(
                 typeQualificationStyle: SymbolDisplayTypeQualificationStyle.NameAndContainingTypes,
                 genericsOptions: SymbolDisplayGenericsOptions.IncludeTypeParameters,
                 miscellaneousOptions: SymbolDisplayMiscellaneousOptions.UseSpecialTypes));
@@ -68,21 +70,22 @@ public static string ToFullyQualifiedName(this Type type)
             switch (type)
             {
                 case { IsGenericParameter: true }: return type.Name;
-                case { IsArray: true }: return type.GetElementType().ToFullyQualifiedName() + "[]";
-                case { IsPointer: true }: return type.GetElementType().ToFullyQualifiedName() + "*";
-                case { IsByRef: true }: return type.GetElementType().ToFullyQualifiedName() + "&";
-                case { IsGenericType: false }: return string.IsNullOrEmpty(type.FullName) ? type.Name : type.FullName.Replace('+', '.');
+                case { IsArray: true }: return type.GetElementType()?.ToFullyQualifiedName() + "[]";
+                case { IsPointer: true }: return type.GetElementType()?.ToFullyQualifiedName() + "*";
+                case { IsByRef: true }: return type.GetElementType()?.ToFullyQualifiedName() + "&";
+                case { IsGenericType: false }:
+                    return string.IsNullOrEmpty(type.FullName) ? type.Name : type.FullName.Replace('+', '.');
                 default:
-                    var fullName = type.GetGenericTypeDefinition().FullName;
+                    var fullName = type.GetGenericTypeDefinition().FullName ?? "";
                     var backTickIndex = fullName.IndexOf('`');
                     if (backTickIndex > 0)
                     {
                         fullName = fullName.Substring(0, backTickIndex);
                     }
 
-                    return fullName.Replace('+', '.') + "<" + string.Join(", ", type.GetGenericArguments().Select(ToFullyQualifiedName)) + ">";
+                    return fullName.Replace('+', '.') + "<" +
+                           string.Join(", ", type.GetGenericArguments().Select(ToFullyQualifiedName)) + ">";
             }
-            ;
         }
     }
 }
@@ -86,7 +86,8 @@ namespace Silk.NET.Maths
                     {{/each}}
                 }
 
-                throw new IndexOutOfRangeException();
+                ThrowHelpers.IndexOutOfRangeException();
+                return ref Row1; // Unreachable, but required to satisfy the compiler.
             }
         }
 

@@ -82,7 +82,8 @@ namespace Silk.NET.Maths
                     {{/each}}
                 }
 
-                throw new ArgumentOutOfRangeException(nameof(index));
+                ThrowHelpers.ArgumentOutOfRangeException_index();
+                return ref {{= Vector.VectorFieldNames[0]}}; // Unreachable, but required to satisfy the compiler.
             }
         }
 
@@ -104,7 +105,7 @@ namespace Silk.NET.Maths
         public {{@Name thisType}}(ReadOnlySpan<T> values)
         {
             if (values.Length != {{= size}})
-                throw new ArgumentException("Input span must contain exactly {{= size}} elements.", nameof(values));
+                ThrowHelpers.ArgumentException_InputSpanTooSmall_{{= size}}();
 
             {{each i in Enumerable.Range(0, size)}}
                 {{= Vector.VectorFieldNames[i]}} = values[{{= i}}];
@@ -129,9 +130,9 @@ namespace Silk.NET.Maths
         public void CopyTo(T[] array, int startIndex)
         {
             if (array == null)
-                throw new ArgumentNullException(nameof(array));
+                ThrowHelpers.ArgumentNullException_array();
             if (startIndex < 0 || startIndex + {{= size}} > array.Length)
-                throw new ArgumentOutOfRangeException(nameof(startIndex));
+                ThrowHelpers.ArgumentOutOfRangeException_startIndex();
 
             {{each i in Enumerable.Range(0, size)}}
                 array[startIndex{{if i != 0}} + {{= i}}{{/if}}] = {{= Vector.VectorFieldNames[i]}};
@@ -145,7 +146,7 @@ namespace Silk.NET.Maths
         public void CopyTo(Span<T> span, int startIndex)
         {
             if (startIndex < 0 || startIndex + {{= size}} > span.Length)
-                throw new ArgumentOutOfRangeException(nameof(startIndex));
+                ThrowHelpers.ArgumentOutOfRangeException_startIndex();
 
             {{each i in Enumerable.Range(0, size)}}
                 span[startIndex{{if i != 0}} + {{= i}}{{/if}}] = {{= Vector.VectorFieldNames[i]}};
@@ -172,7 +173,7 @@ namespace Silk.NET.Maths
         public static {{@Name thisType}}<T> Parse(ReadOnlySpan<char> s, IFormatProvider? provider)
         {
             if (!TryParse(s, provider, out var result))
-                throw new FormatException("Invalid format for {{@Name thisType}}.");
+                ThrowHelpers.FormatException_InvalidFormat{{@Name thisType}}();
 
             return result;
         }

@@ -78,7 +78,8 @@ public ref Vector2D<T> this[int row]
                         return ref Row2;
                 }
 
-                throw new IndexOutOfRangeException();
+                ThrowHelpers.IndexOutOfRangeException();
+                return ref Row1; // Unreachable, but required to satisfy the compiler.
             }
         }
 

@@ -83,7 +83,8 @@ public ref Vector3D<T> this[int row]
                         return ref Row2;
                 }
 
-                throw new IndexOutOfRangeException();
+                ThrowHelpers.IndexOutOfRangeException();
+                return ref Row1; // Unreachable, but required to satisfy the compiler.
             }
         }
 

@@ -97,7 +97,8 @@ public ref Vector4D<T> this[int row]
                         return ref Row2;
                 }
 
-                throw new IndexOutOfRangeException();
+                ThrowHelpers.IndexOutOfRangeException();
+                return ref Row1; // Unreachable, but required to satisfy the compiler.
             }
         }
 

@@ -85,7 +85,8 @@ public ref Vector2D<T> this[int row]
                         return ref Row3;
                 }
 
-                throw new IndexOutOfRangeException();
+                ThrowHelpers.IndexOutOfRangeException();
+                return ref Row1; // Unreachable, but required to satisfy the compiler.
             }
         }
 

@@ -114,7 +114,8 @@ public ref Vector3D<T> this[int row]
                         return ref Row3;
                 }
 
-                throw new IndexOutOfRangeException();
+                ThrowHelpers.IndexOutOfRangeException();
+                return ref Row1; // Unreachable, but required to satisfy the compiler.
             }
         }
 

@@ -123,7 +123,8 @@ public ref Vector4D<T> this[int row]
                         return ref Row3;
                 }
 
-                throw new IndexOutOfRangeException();
+                ThrowHelpers.IndexOutOfRangeException();
+                return ref Row1; // Unreachable, but required to satisfy the compiler.
             }
         }
 

@@ -101,7 +101,8 @@ public ref Vector2D<T> this[int row]
                         return ref Row4;
                 }
 
-                throw new IndexOutOfRangeException();
+                ThrowHelpers.IndexOutOfRangeException();
+                return ref Row1; // Unreachable, but required to satisfy the compiler.
             }
         }
 

@@ -564,10 +564,10 @@ public static Matrix4X3<T> CreatePerspectiveRH<T>(T width, T height, T nearPlane
             where T : INumber<T>
         {
             if (!(nearPlaneDistance > T.Zero))
-                throw new ArgumentOutOfRangeException(nameof(nearPlaneDistance));
+                ThrowHelpers.ArgumentOutOfRangeException_nearPlaneDistance();
 
             if (!(farPlaneDistance > T.Zero))
-                throw new ArgumentOutOfRangeException(nameof(farPlaneDistance));
+                ThrowHelpers.ArgumentOutOfRangeException_farPlaneDistance();
 
             Matrix4X3<T> result = default;
 
@@ -599,10 +599,10 @@ public static Matrix4X3<T> CreatePerspectiveLH<T>(T width, T height, T nearPlane
             where T : INumber<T>
         {
             if (!(nearPlaneDistance > T.Zero))
-                throw new ArgumentOutOfRangeException(nameof(nearPlaneDistance));
+                ThrowHelpers.ArgumentOutOfRangeException_nearPlaneDistance();
 
             if (!(farPlaneDistance > T.Zero))
-                throw new ArgumentOutOfRangeException(nameof(farPlaneDistance));
+                ThrowHelpers.ArgumentOutOfRangeException_farPlaneDistance();
 
             Matrix4X3<T> result = default;
 
@@ -634,13 +634,13 @@ public static Matrix4X3<T> CreatePerspectiveFieldOfViewRH<T>(T fieldOfView, T as
             where T : INumber<T>, ITrigonometricFunctions<T>
         {
             if (!(fieldOfView > T.Zero) || (fieldOfView >= T.Pi))
-                throw new ArgumentOutOfRangeException(nameof(fieldOfView));
+                ThrowHelpers.ArgumentOutOfRangeException_fieldOfView();
 
             if (!(nearPlaneDistance > T.Zero))
-                throw new ArgumentOutOfRangeException(nameof(nearPlaneDistance));
+                ThrowHelpers.ArgumentOutOfRangeException_nearPlaneDistance();
 
             if (!(farPlaneDistance > T.Zero))
-                throw new ArgumentOutOfRangeException(nameof(farPlaneDistance));
+                ThrowHelpers.ArgumentOutOfRangeException_farPlaneDistance();
 
             T yScale = T.One / T.Tan(fieldOfView / T.CreateTruncating(2));
             T xScale = yScale / aspectRatio;
@@ -673,13 +673,13 @@ public static Matrix4X3<T> CreatePerspectiveFieldOfViewLH<T>(T fieldOfView, T as
             where T : INumber<T>, ITrigonometricFunctions<T>
         {
             if (!(fieldOfView > T.Zero) || (fieldOfView >= T.Pi))
-                throw new ArgumentOutOfRangeException(nameof(fieldOfView));
+                ThrowHelpers.ArgumentOutOfRangeException_fieldOfView();
 
             if (!(nearPlaneDistance > T.Zero))
-                throw new ArgumentOutOfRangeException(nameof(nearPlaneDistance));
+                ThrowHelpers.ArgumentOutOfRangeException_nearPlaneDistance();
 
             if (!(farPlaneDistance > T.Zero))
-                throw new ArgumentOutOfRangeException(nameof(farPlaneDistance));
+                ThrowHelpers.ArgumentOutOfRangeException_farPlaneDistance();
 
             T yScale = T.One / T.Tan(fieldOfView / T.CreateTruncating(2));
             T xScale = yScale / aspectRatio;
@@ -714,10 +714,10 @@ public static Matrix4X3<T> CreatePerspectiveOffCenterRH<T>(T left, T right, T bo
             where T : INumber<T>
         {
             if (!(nearPlaneDistance > T.Zero))
-                throw new ArgumentOutOfRangeException(nameof(nearPlaneDistance));
+                ThrowHelpers.ArgumentOutOfRangeException_nearPlaneDistance();
 
             if (!(farPlaneDistance > T.Zero))
-                throw new ArgumentOutOfRangeException(nameof(farPlaneDistance));
+                ThrowHelpers.ArgumentOutOfRangeException_farPlaneDistance();
 
             Matrix4X3<T> result = default;
 
@@ -750,10 +750,10 @@ public static Matrix4X3<T> CreatePerspectiveOffCenterLH<T>(T left, T right, T bo
             where T : INumber<T>
         {
             if (!(nearPlaneDistance > T.Zero))
-                throw new ArgumentOutOfRangeException(nameof(nearPlaneDistance));
+                ThrowHelpers.ArgumentOutOfRangeException_nearPlaneDistance();
 
             if (!(farPlaneDistance > T.Zero))
-                throw new ArgumentOutOfRangeException(nameof(farPlaneDistance));
+                ThrowHelpers.ArgumentOutOfRangeException_farPlaneDistance();
 
             Matrix4X3<T> result = default;
 

@@ -125,7 +125,8 @@ public ref Vector3D<T> this[int row]
                         return ref Row4;
                 }
 
-                throw new IndexOutOfRangeException();
+                ThrowHelpers.IndexOutOfRangeException();
+                return ref Row1; // Unreachable, but required to satisfy the compiler.
             }
         }