reduce capacity checks & collections marshall calls

Perksey · Feb 15, 2025 · Feb 22, 2025 · Mar 15, 2025 · Apr 5, 2025 · May 25, 2025
commit 4c87bc3766630e5d36a78fc6851a09a5ccd424ee
@@ -31,9 +31,10 @@ private unsafe ref TargetPoint CreateOrUpdateTargetPoint(IPointerTarget target,
         int? pointIndex = null;
         int? defaultIndex = null;
 
-        for (var i = 0; i < _actualPoints.Count; i++)
+        var actualPointsSpan = CollectionsMarshal.AsSpan(_actualPoints);
+        for (var i = 0; i < actualPointsSpan.Length; i++)
         {
-            var candidatePoint = GetPointRef(i);
+            ref readonly var candidatePoint = ref actualPointsSpan[i];
             if (candidatePoint.Target == target && candidatePoint.Id == touchId)
             {
                 pointIndex = i;
@@ -50,14 +51,16 @@ private unsafe ref TargetPoint CreateOrUpdateTargetPoint(IPointerTarget target,
         if (pointIndex == null)
         {
             pointIndex = defaultIndex ?? _actualPoints.Count;
+            EnsurePointsListCapacity(pointIndex.Value, _actualPoints);
+            actualPointsSpan = CollectionsMarshal.AsSpan(_actualPoints);
             isNewPoint = true;
         }
         else
         {
             isNewPoint = false;
         }
 
-        ref var point = ref GetPointRef(pointIndex.Value);
+        ref var point = ref actualPointsSpan[pointIndex.Value];
 
         // note: a null oldPoint means this is a new point
         // see PointChangedEvent for more info
@@ -201,9 +204,10 @@ protected void AddOrUpdatePoint(uint? touchId, IPointerTarget target, in Vector3
             // point was actually removed - after that point changed event, we should remove it
             // note - a null newPoint means the point was removed
             var previous = point;
-            for (var i = 0; i < _actualPoints.Count; i++)
+            var actualPoints = CollectionsMarshal.AsSpan(_actualPoints);
+            for (var i = 0; i < actualPoints.Length; i++)
             {
-                ref var candidatePoint = ref GetPointRef(i);
+                ref var candidatePoint = ref actualPoints[i];
                 if (candidatePoint.Id == previous.Id)
                 {
                     candidatePoint = default;
@@ -270,15 +274,13 @@ protected void UpdatePointRay(uint? touchId, IPointerTarget target, float? xTilt
             NewPoint: point), sdlTimestamp);
     }
 
-    private ref TargetPoint GetPointRef(int index)
+    private static void EnsurePointsListCapacity(int index, List<TargetPoint> actualPoints)
     {
-        _actualPoints.EnsureCapacity(index + 1);
-        while (index >= _actualPoints.Count)
+        actualPoints.EnsureCapacity(index + 1);
+        while (index >= actualPoints.Count)
         {
-            _actualPoints.Add(default);
+            actualPoints.Add(default);
         }
-
-        return ref CollectionsMarshal.AsSpan(_actualPoints)[index];
     }
 
     public void TargetDestroyed(IPointerTarget target, long timestamp, ulong sdlTimestamp)