Repository navigation
Conversation
Signed-off-by: Ankit Kumar <ankitkumar19473@gmail.com>
Contributor
|
✅ DCO Check Passed Thanks @ankit2235, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_extract_verbatim_contentonly skipped an optional[...]after\begin{env}, using a non-greedy\[.*?\]. Two cases leaked markup into the code item:mintedtakes a mandatory language argument, which became the first line of the code:\begin{minted}{python}gave{python}\nx = 1.lstlistingoption value containing], such ascaption={A [nested] cap}, ended the option match early and leftcap}]in the code.The pattern now skips an optional argument whose
{...}values may contain brackets, and, formintedonly, the{language}argument after it.verbatim, plainlstlisting, multi-line options, and code that itself starts with[or{behave as before.The new parametrized test covers
mintedwith and without options andlstlistingwith a bracketed caption, with an indented code line so the first-line indentation from #4502 stays covered. It fails onmainand passes with this change; the other LaTeX tests pass unchanged.Using minted's language (or lstlisting's
language=) as the code item's language is left for a follow-up.Issue resolved by this Pull Request:
Resolves #4542
Checklist: