Skip to content

Fix RestartPolicy.noRestart() so it can disable restart on existing containers #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcongithub wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix RestartPolicy.noRestart() so it can disable restart on existing containers #2674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix RestartPolicy.noRestart() so it can disable restart on existing c… 
…ontainers

noRestart() returned a policy with an empty Name (""), which the Docker Engine
update endpoint ignores: it only applies RestartPolicy when Name != "". As a
result an existing container could not be switched from always/on-failure back
to no-restart via updateContainerCmd.

Return Name "no" instead - a valid "none" policy (RestartPolicy.IsNone() is true
for both "" and "no") that the daemon actually applies. Update
RestartPolicySerializingTest to match; this also matches what modern Docker sends
for `docker run --restart no`.
  • Loading branch information
jcheng422
jcheng422 committed Aug 17, 2026
commit f31ea1c5b5588a0c41cf751ff1ebb5b4ccf27d46
2 changes: 1 addition & 1 deletion docker-java-api/src/main/java/com/github/dockerjava/api/model/RestartPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ private RestartPolicy(int maximumRetryCount, String name) {
* Do not restart the container if it dies. (default)
*/
public static RestartPolicy noRestart() {
return new RestartPolicy();
return new RestartPolicy(0, "no");
}

/**
Expand Down
2 changes: 1 addition & 1 deletion docker-java/src/test/java/com/github/dockerjava/api/model/RestartPolicySerializingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class RestartPolicySerializingTest {
// --restart no
public void noRestart() throws Exception {
String json = JSONTestHelper.getMapper().writeValueAsString(RestartPolicy.noRestart());
assertEquals("{\"MaximumRetryCount\":0,\"Name\":\"\"}", json);
assertEquals("{\"MaximumRetryCount\":0,\"Name\":\"no\"}", json);
}

@Test
Expand Down