Use long rather than int for sizeRw and sizeRootFs - #2230
Merged
Merged
Conversation
eddumelendez
approved these changes
Dec 19, 2023
Member
|
Thanks for your contribution, @LarsSven ! |
eddumelendez
added a commit
that referenced
this pull request
Dec 20, 2023
This reverts commit 84d7750.
eddumelendez
added a commit
that referenced
this pull request
Dec 21, 2023
This reverts commit 84d7750.
|
Thanks guys.When can it be released? |
Member
|
I'm planning to revert this one due to the breaking changes. See #2279 |
eddumelendez
added a commit
that referenced
this pull request
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently docker-java uses an integer to represent SizeRw and SizeRootFs. This value however represents the an amount of bytes, meaning the integer could easily overflow.
This MR changes these two fields to longs.
Note that Container.java also implements a SizeRw and SizeRootFs fields. Here, the fields are represented as longs rather than integers, so it would make sense that the inspect container command also returns longs.