Skip to content

fix(2127): handle repoNames with tags - #2128

Merged
eddumelendez merged 2 commits into
docker-java:mainfrom
setchy:feature/2127-support-tag-and-digest-2
Jun 19, 2023
Merged

eddumelendez merged 2 commits into
docker-java:mainfrom
setchy:feature/2127-support-tag-and-digest-2

Conversation

@setchy

@setchy setchy commented Jun 2, 2023 •

Copy link
Copy Markdown
Contributor

This update improved the handling for resolveRepositoryName when the image statement includes a registry and tags.

Current behavior will throw the error as reported in the issue

Resolves: #2127 - confirmed by @leomao10

@setchy
setchy requested a review from a team as a code owner June 2, 2023 20:55
@setchy

setchy commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

@eddumelendez - could you kindly review this PR 🙏

@eddumelendez eddumelendez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eddumelendez
eddumelendez merged commit dd0de7c into docker-java:main Jun 19, 2023
@eddumelendez

Copy link
Copy Markdown
Member

Thanks for your contribution, @setchy !

@eddumelendez eddumelendez added this to the next milestone Jun 19, 2023
@setchy

setchy commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @eddumelendez for the speedy review. Greatly appreciated 🙏

@setchy

setchy commented Jun 20, 2023

Copy link
Copy Markdown
Contributor Author

@eddumelendez - to help with my internal sprint planning and stakeholder mgmt, can you educate my about the release cadence for docker-java

@eddumelendez

Copy link
Copy Markdown
Member

There is no release schedule but as soon there are many good improvement features we will do the release. Indeed, I'm just waiting for other PR to perform it.

@setchy
setchy deleted the feature/2127-support-tag-and-digest-2 branch July 5, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse Docker images of <name>:<tag>@sha256:<hash> format

2 participants