Skip to content

Use npipe as the default DOCKER_HOST on Windows #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsideup merged 2 commits into from
Sep 9, 2021
Merged

Use npipe as the default DOCKER_HOST on Windows #1701

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42f2162
support default config by windows
ziminghua Sep 3, 2021
adf854e
Update DefaultDockerClientConfig.java
bsideup Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docker-java-core/src/main/java/com/github/dockerjava/core/DefaultDockerClientConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ public class DefaultDockerClientConfig implements Serializable, DockerClientConf
static final Properties DEFAULT_PROPERTIES = new Properties();

static final String DEFAULT_DOCKER_HOST = "unix:///var/run/docker.sock";

static final String WINDOWS_DEFAULT_DOCKER_HOST = "npipe:////./pipe/docker_engine";

static {
CONFIG_KEYS.add(DOCKER_HOST);
Expand Down Expand Up @@ -444,7 +446,8 @@ public DefaultDockerClientConfig build() {
sslConfig = customSslConfig;
}

URI dockerHostUri = (dockerHost != null) ? dockerHost : URI.create(DEFAULT_DOCKER_HOST);
String defaultHost = SystemUtils.IS_OS_WINDOWS ? WINDOWS_DEFAULT_DOCKER_HOST : DEFAULT_DOCKER_HOST;
URI dockerHostUri = (dockerHost != null) ? dockerHost : URI.create(defaultHost);

return new DefaultDockerClientConfig(dockerHostUri, dockerConfig, apiVersion, registryUrl, registryUsername,
registryPassword, registryEmail, sslConfig);
Expand Down