Skip to content

Add DefaultDockerClientConfig.Builder#isDockerHostSetExplicitly #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsideup merged 9 commits into from
Aug 23, 2021
Merged

Add DefaultDockerClientConfig.Builder#isDockerHostSetExplicitly #1692

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
28323ad
Add getter for checking if dockerHost in DefaultDockerClientConfig.Bu…
kiview Aug 23, 2021
0aed76a
Report as not-implicit even if default value was applied by user
kiview Aug 23, 2021
317351d
Invert logo to `isDockerHostSetExplicit()`
kiview Aug 23, 2021
fa21e02
Refactor and simplify
kiview Aug 23, 2021
8888cb5
Minimize changeset
kiview Aug 23, 2021
2541d31
Only use DOCKER_HOST from Properties if not null
kiview Aug 23, 2021
41180ba
Minimize diff
kiview Aug 23, 2021
df92cb5
Better grammar
kiview Aug 23, 2021
b20fb37
Update DefaultDockerClientConfigTest.java
bsideup Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minimize diff
  • Loading branch information
@kiview
kiview committed Aug 23, 2021
commit 41180bae89b6a1fc027c8bd2609fe7ff65252d32
1 change: 0 additions & 1 deletion docker-java-core/src/main/java/com/github/dockerjava/core/DefaultDockerClientConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ private static Properties overrideDockerPropertiesWithSystemProperties(Propertie
overriddenProperties.setProperty(key, systemProperties.getProperty(key));
}
}

return overriddenProperties;
}

Expand Down